You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "valepakh (via GitHub)" <gi...@apache.org> on 2024/11/13 16:52:18 UTC
[PR] IGNITE-23671 Fix IterableToPublisherAdapter [ignite-3]
valepakh opened a new pull request, #4719:
URL: https://github.com/apache/ignite-3/pull/4719
https://issues.apache.org/jira/browse/IGNITE-23671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23671 Fix IterableToPublisherAdapter [ignite-3]
Posted by "Pochatkin (via GitHub)" <gi...@apache.org>.
Pochatkin merged PR #4719:
URL: https://github.com/apache/ignite-3/pull/4719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23671 Fix IterableToPublisherAdapter [ignite-3]
Posted by "valepakh (via GitHub)" <gi...@apache.org>.
valepakh commented on code in PR #4719:
URL: https://github.com/apache/ignite-3/pull/4719#discussion_r1841884846
##########
modules/core/src/main/java/org/apache/ignite/internal/util/subscription/IterableToPublisherAdapter.java:
##########
@@ -162,7 +162,7 @@ private void drain() {
notifyError(th);
}
- if (amount > 0) {
+ if (!it.hasNext() || amount == 0) {
Review Comment:
> why do we need the second part of the condition (` || amount == 0`)?
We don't need it actually, removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23671 Fix IterableToPublisherAdapter [ignite-3]
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 commented on code in PR #4719:
URL: https://github.com/apache/ignite-3/pull/4719#discussion_r1841875543
##########
modules/core/src/main/java/org/apache/ignite/internal/util/subscription/IterableToPublisherAdapter.java:
##########
@@ -162,7 +162,7 @@ private void drain() {
notifyError(th);
}
- if (amount > 0) {
+ if (!it.hasNext() || amount == 0) {
Review Comment:
why do we need the second part of the condition (` || amount == 0`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org