You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/01 03:43:50 UTC

[GitHub] [tvm] xqdan commented on pull request #8079: Complete register op from python

xqdan commented on pull request #8079:
URL: https://github.com/apache/tvm/pull/8079#issuecomment-851782689


   > Hi @xqdan,
   > 
   > Sorry for the late reply.
   > This PR is very useful.
   > (Actually I already use this PR to do some experiments, thanks a lot 👍)
   > 
   > I am wondering if you have plan to make it more like C++ API (eg export TypeReporter, etc).
   > I agree with @altanh, should clarify what is done and what is not done, so users could quickly catch up.
   > I can only think about adding comments/documents, maybe you and others may come up with better idea?
   
   Thanks for review.  @zackcquic 
   I think it's possible to expose TypeReporter to python side, in this PR, as your suggestion, I put more comments for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org