[jira] [Commented] (GEODE-8367) Stopped parallel gateway sender still adds events into tmpDroppedEvents

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159645#comment-17159645 ] 

ASF GitHub Bot commented on GEODE-8367:
---------------------------------------

gesterzhou opened a new pull request #5381:
URL: https://github.com/apache/geode/pull/5381


   …o tmpDroppedEvents
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Stopped parallel gateway sender still adds events into tmpDroppedEvents
> -----------------------------------------------------------------------
>
>                 Key: GEODE-8367
>                 URL: https://issues.apache.org/jira/browse/GEODE-8367
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Xiaojian Zhou
>            Priority: Major
>
> In GEODE-4942, we introduced tmpDroppedEvents to save the in-coming events when the parallel gateway sender is restarting. However, we did not consider the case that the sender could be purposely stopped. 
> Even for the stopped sender, the events are continuously saved into tmpDroppedEvents, which used a lot of memory. 
> We should determine if the sender is in the middle of restarting or purposely stopped. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)