[GitHub] [ozone] errose28 commented on a diff in pull request #5065: HDDS-8896. Remove -skipTrash option from sh key delete command.

["errose28 (via GitHub)" <gi...@apache.org>]

errose28 commented on code in PR #5065:
URL: https://github.com/apache/ozone/pull/5065#discussion_r1264156209


##########
hadoop-ozone/dist/src/main/smoketest/basic/ozone-shell-lib.robot:
##########
@@ -72,7 +72,7 @@ Test ozone shell
                     Execute             ozone sh bucket clrquota --namespace-quota ${protocol}${server}/${volume}/bb1
     ${result} =     Execute             ozone sh bucket info ${protocol}${server}/${volume}/bb1 | jq -r '. | select(.name=="bb1") | .quotaInNamespace'
                     Should Be Equal     ${result}       -1
-                    Execute             ozone sh bucket delete ${protocol}${server}/${volume}/bb1
+                    Execute             ozone sh bucket delete -r --yes ${protocol}${server}/${volume}/bb1

Review Comment:
   Do we need the recursive option added to the bucket delete here? Is there a case where trash is remaining when this keyword is called?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org