You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tr...@apache.org on 2018/07/12 15:04:58 UTC
flink git commit: [hotfix] Correct checkstyle violations in
RestartStrategies
Repository: flink
Updated Branches:
refs/heads/master def2aed5c -> b407ba792
[hotfix] Correct checkstyle violations in RestartStrategies
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/b407ba79
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/b407ba79
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/b407ba79
Branch: refs/heads/master
Commit: b407ba792e899fedea0d83ab566633070e83e7fc
Parents: def2aed
Author: Till Rohrmann <tr...@apache.org>
Authored: Thu Jul 12 17:02:33 2018 +0200
Committer: Till Rohrmann <tr...@apache.org>
Committed: Thu Jul 12 17:02:57 2018 +0200
----------------------------------------------------------------------
.../restartstrategy/RestartStrategies.java | 26 ++++++++++++++------
1 file changed, 19 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/b407ba79/flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java b/flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java
index fc24fe7..f3eb3a5 100644
--- a/flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java
+++ b/flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java
@@ -28,13 +28,13 @@ import java.util.concurrent.TimeUnit;
* This class defines methods to generate RestartStrategyConfigurations. These configurations are
* used to create RestartStrategies at runtime.
*
- * The RestartStrategyConfigurations are used to decouple the core module from the runtime module.
+ * <p>The RestartStrategyConfigurations are used to decouple the core module from the runtime module.
*/
@PublicEvolving
public class RestartStrategies {
/**
- * Generates NoRestartStrategyConfiguration
+ * Generates NoRestartStrategyConfiguration.
*
* @return NoRestartStrategyConfiguration
*/
@@ -80,20 +80,26 @@ public class RestartStrategies {
return new FailureRateRestartStrategyConfiguration(failureRate, failureInterval, delayInterval);
}
+ /**
+ * Abstract configuration for restart strategies.
+ */
public abstract static class RestartStrategyConfiguration implements Serializable {
private static final long serialVersionUID = 6285853591578313960L;
private RestartStrategyConfiguration() {}
/**
- * Returns a description which is shown in the web interface
+ * Returns a description which is shown in the web interface.
*
* @return Description of the restart strategy
*/
public abstract String getDescription();
}
- final public static class NoRestartStrategyConfiguration extends RestartStrategyConfiguration {
+ /**
+ * Configuration representing no restart strategy.
+ */
+ public static final class NoRestartStrategyConfiguration extends RestartStrategyConfiguration {
private static final long serialVersionUID = -5894362702943349962L;
@Override
@@ -102,7 +108,10 @@ public class RestartStrategies {
}
}
- final public static class FixedDelayRestartStrategyConfiguration extends RestartStrategyConfiguration {
+ /**
+ * Configuration representing a fixed delay restart strategy.
+ */
+ public static final class FixedDelayRestartStrategyConfiguration extends RestartStrategyConfiguration {
private static final long serialVersionUID = 4149870149673363190L;
private final int restartAttempts;
@@ -146,7 +155,10 @@ public class RestartStrategies {
}
}
- final public static class FailureRateRestartStrategyConfiguration extends RestartStrategyConfiguration {
+ /**
+ * Configuration representing a failure rate restart strategy.
+ */
+ public static final class FailureRateRestartStrategyConfiguration extends RestartStrategyConfiguration {
private static final long serialVersionUID = 1195028697539661739L;
private final int maxFailureRate;
@@ -183,7 +195,7 @@ public class RestartStrategies {
* strategy. Useful especially when one has a custom implementation of restart strategy set via
* flink-conf.yaml.
*/
- final public static class FallbackRestartStrategyConfiguration extends RestartStrategyConfiguration{
+ public static final class FallbackRestartStrategyConfiguration extends RestartStrategyConfiguration{
private static final long serialVersionUID = -4441787204284085544L;
@Override