You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Justin Edelson (JIRA)" <ji...@apache.org> on 2010/07/14 03:06:50 UTC
[jira] Created: (SLING-1595) Add a jcr:path property to
JcrPropertyMap
Add a jcr:path property to JcrPropertyMap
-----------------------------------------
Key: SLING-1595
URL: https://issues.apache.org/jira/browse/SLING-1595
Project: Sling
Issue Type: Improvement
Components: JCR
Reporter: Justin Edelson
Fix For: JCR Resource 2.0.8
Although it can be computed, it would be nice to always have access to a jcr:path property via the ValueMap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1595) Add a jcr:path property to
JcrPropertyMap
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson resolved SLING-1595.
-----------------------------------
Resolution: Won't Fix
> Add a jcr:path property to JcrPropertyMap
> -----------------------------------------
>
> Key: SLING-1595
> URL: https://issues.apache.org/jira/browse/SLING-1595
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Reporter: Justin Edelson
> Fix For: JCR Resource 2.0.8
>
>
> Although it can be computed, it would be nice to always have access to a jcr:path property via the ValueMap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1595) Add a jcr:path property to
JcrPropertyMap
Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888262#action_12888262 ]
Alexander Klimetschek commented on SLING-1595:
----------------------------------------------
I agree with Carsten. What would be the use case? Normally you always have the originating resource at hand to get its path directly.
> Add a jcr:path property to JcrPropertyMap
> -----------------------------------------
>
> Key: SLING-1595
> URL: https://issues.apache.org/jira/browse/SLING-1595
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Reporter: Justin Edelson
> Fix For: JCR Resource 2.0.8
>
>
> Although it can be computed, it would be nice to always have access to a jcr:path property via the ValueMap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1595) Add a jcr:path property to
JcrPropertyMap
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888207#action_12888207 ]
Carsten Ziegeler commented on SLING-1595:
-----------------------------------------
I'm not sure about this - I have at least three issues/questions with it:
- the jcr property map allows to specify a path to property to get a prop of a child node like "foo/barprop". *If* we would support jcr:path we, should we also support jcr:path for child nodes like foo/jcr:path (ok, getting jcr:path and appending /foo would get me the path as well)?
- A lot of code I know relies on iterating over the props - with a new prop jcr:path this would be returned in the iterator as well which might create problems.
- This is a special jcr prop which is not available for other value map implementations - so maybe we need something more generic?
> Add a jcr:path property to JcrPropertyMap
> -----------------------------------------
>
> Key: SLING-1595
> URL: https://issues.apache.org/jira/browse/SLING-1595
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Reporter: Justin Edelson
> Fix For: JCR Resource 2.0.8
>
>
> Although it can be computed, it would be nice to always have access to a jcr:path property via the ValueMap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1595) Add a jcr:path property to
JcrPropertyMap
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888299#action_12888299 ]
Justin Edelson commented on SLING-1595:
---------------------------------------
Hmmm. OK. The problem I'm running in to is that the JSON representation of a resource doesn't have the path in it. So downstream consumers need two bits of data: the JSON object and the requested path.
These are very valid concerns, so I'll look for another solution, probably by enabling more customization in the GET servlet.
> Add a jcr:path property to JcrPropertyMap
> -----------------------------------------
>
> Key: SLING-1595
> URL: https://issues.apache.org/jira/browse/SLING-1595
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Reporter: Justin Edelson
> Fix For: JCR Resource 2.0.8
>
>
> Although it can be computed, it would be nice to always have access to a jcr:path property via the ValueMap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1595) Add a jcr:path property to
JcrPropertyMap
Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888383#action_12888383 ]
Alexander Klimetschek commented on SLING-1595:
----------------------------------------------
> The problem I'm running in to is that the JSON representation of a resource doesn't have the path in it.
Ok, but they have the path of the original requested object, at least for a default json get request.
I had a similar case when building a servlet that returned json objects for a query result - where each item can have a different path. But I just re-used the JsonItemWriter in that case: I added the path myself and had the JsonItemWriter do the rest (had to override a method, though).
But I think in any case this generally is an issue of the json representation, not the ValueMap semantics. So a solution should enhance whatever creates the JSON output, but not the ValueMap directly.
> Add a jcr:path property to JcrPropertyMap
> -----------------------------------------
>
> Key: SLING-1595
> URL: https://issues.apache.org/jira/browse/SLING-1595
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Reporter: Justin Edelson
> Fix For: JCR Resource 2.0.8
>
>
> Although it can be computed, it would be nice to always have access to a jcr:path property via the ValueMap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1595) Add a jcr:path property to
JcrPropertyMap
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888137#action_12888137 ]
Justin Edelson commented on SLING-1595:
---------------------------------------
patch here: http://codereview.appspot.com/1815043
> Add a jcr:path property to JcrPropertyMap
> -----------------------------------------
>
> Key: SLING-1595
> URL: https://issues.apache.org/jira/browse/SLING-1595
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Reporter: Justin Edelson
> Fix For: JCR Resource 2.0.8
>
>
> Although it can be computed, it would be nice to always have access to a jcr:path property via the ValueMap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.