You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2019/12/06 15:00:17 UTC
[qpid-jms] branch master updated: QPIDJMS-482: update to proton-j
0.33.3, and update tests for QPIDJMS-481.
This is an automated email from the ASF dual-hosted git repository.
robbie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-jms.git
The following commit(s) were added to refs/heads/master by this push:
new 274bd97 QPIDJMS-482: update to proton-j 0.33.3, and update tests for QPIDJMS-481.
274bd97 is described below
commit 274bd97fda17a93e4877d08b30a8032f63ffeb8a
Author: Robbie Gemmell <ro...@apache.org>
AuthorDate: Fri Dec 6 14:17:44 2019 +0000
QPIDJMS-482: update to proton-j 0.33.3, and update tests for QPIDJMS-481.
---
pom.xml | 2 +-
.../jms/integration/TransactionsIntegrationTest.java | 17 ++++++-----------
2 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/pom.xml b/pom.xml
index 2723642..4476714 100644
--- a/pom.xml
+++ b/pom.xml
@@ -39,7 +39,7 @@
<maven.compiler.target>1.8</maven.compiler.target>
<!-- Dependency Versions for this Project -->
- <proton-version>0.33.2</proton-version>
+ <proton-version>0.33.3</proton-version>
<netty-version>4.1.43.Final</netty-version>
<slf4j-version>1.7.25</slf4j-version>
<geronimo.jms.2.spec.version>1.0-alpha-2</geronimo.jms.2.spec.version>
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/TransactionsIntegrationTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/TransactionsIntegrationTest.java
index 42dbada..5eeecdb 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/TransactionsIntegrationTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/TransactionsIntegrationTest.java
@@ -65,6 +65,7 @@ import org.apache.qpid.jms.test.testpeer.describedtypes.Released;
import org.apache.qpid.jms.test.testpeer.describedtypes.TransactionalState;
import org.apache.qpid.jms.test.testpeer.describedtypes.sections.AmqpValueDescribedType;
import org.apache.qpid.jms.test.testpeer.matchers.AcceptedMatcher;
+import org.apache.qpid.jms.test.testpeer.matchers.ErrorMatcher;
import org.apache.qpid.jms.test.testpeer.matchers.ModifiedMatcher;
import org.apache.qpid.jms.test.testpeer.matchers.ReleasedMatcher;
import org.apache.qpid.jms.test.testpeer.matchers.SourceMatcher;
@@ -1706,12 +1707,10 @@ public class TransactionsIntegrationTest extends QpidJmsTestCase {
// Expect declare, reply declared but without a txn-id, which is illegal.
testPeer.expectDeclare(null);
- // TODO: swap this in for below after PROTON-2142 fix is available:
- // ErrorMatcher errorMatcher = new ErrorMatcher()
- // .withCondition(equalTo(AmqpError.DECODE_ERROR))
- // .withDescription(equalTo("The txn-id field cannot be omitted"));
- // testPeer.expectClose(errorMatcher, false);
- testPeer.expectClose(false);
+ ErrorMatcher errorMatcher = new ErrorMatcher()
+ .withCondition(equalTo(AmqpError.DECODE_ERROR))
+ .withDescription(equalTo("The txn-id field cannot be omitted"));
+ testPeer.expectClose(errorMatcher, false);
testPeer.setSuppressReadExceptionOnClose(true);
try {
@@ -1725,12 +1724,8 @@ public class TransactionsIntegrationTest extends QpidJmsTestCase {
JMSException ex = failure.get();
assertTrue("Unexpected exception type: " + ex, ex instanceof JmsConnectionFailedException);
- // TODO: swap this in for below after PROTON-2142 fix is available:
- // MatcherAssert.assertThat("Unexpected exception type: ", ex.getMessage(),
- // equalTo("The JMS connection has failed: Error in proton Transport: The txn-id field cannot be omitted [condition = amqp:decode-error]"));
MatcherAssert.assertThat("Unexpected exception type: ", ex.getMessage(),
- equalTo("The JMS connection has failed: Error in proton Transport: org.apache.qpid.proton.engine.TransportException: "
- + "org.apache.qpid.proton.codec.DecodeException: The txn-id field cannot be omitted [condition = amqp:connection:framing-error]"));
+ equalTo("The JMS connection has failed: Error in proton Transport: The txn-id field cannot be omitted [condition = amqp:decode-error]"));
testPeer.waitForAllHandlersToComplete(1000);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org