You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/03/27 15:34:13 UTC
Review Request 66307: Added implicit conversion from nullptr to Owned
and Shared.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66307/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
Repository: mesos
Description
-------
To communicate absence of a reference we usually use `nullptr` inside
smart pointers. This patch adds smart pointer constructors from
`nullptr_t` which mirror conversion present in `std::unique_ptr` and
`std::shared_ptr` simplifying such use cases.
Diffs
-----
3rdparty/libprocess/include/process/owned.hpp cc149e78165d42f1243168c34fc64fd121c6c83f
3rdparty/libprocess/include/process/shared.hpp 6eb69439d21897398157b2d400a00c49ea720e68
Diff: https://reviews.apache.org/r/66307/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 66307: Added implicit conversion from nullptr to
Owned and Shared.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66307/#review200074
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On March 27, 2018, 3:34 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66307/
> -----------------------------------------------------------
>
> (Updated March 27, 2018, 3:34 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To communicate absence of a reference we usually use `nullptr` inside
> smart pointers. This patch adds smart pointer constructors from
> `nullptr_t` which mirror conversion present in `std::unique_ptr` and
> `std::shared_ptr` simplifying such use cases.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/owned.hpp cc149e78165d42f1243168c34fc64fd121c6c83f
> 3rdparty/libprocess/include/process/shared.hpp 6eb69439d21897398157b2d400a00c49ea720e68
>
>
> Diff: https://reviews.apache.org/r/66307/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>