You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/24 04:10:14 UTC
[GitHub] [incubator-tvm] masahi edited a comment on issue #4771: [Relay]
Added Merge Composite pass
masahi edited a comment on issue #4771: [Relay] Added Merge Composite pass
URL: https://github.com/apache/incubator-tvm/pull/4771#issuecomment-577983004
From your test cases, I don't see why this pass would help remove pattern matching on codegen side. Since Relay doesn't have `add_sub_mul` op, I still need to first find multiply, then traverse further to find sub etc, no? From the codegen side I don't see the difference compared to manual partitioning. Or is that part of another future PR?
It definitely removes the need for writing custom annotator for each pattern, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services