You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/14 20:43:25 UTC

[GitHub] [kafka] rondagostino opened a new pull request #10538: MINOR: shutdown KafkaScheduler at appropriate time

rondagostino opened a new pull request #10538:
URL: https://github.com/apache/kafka/pull/10538


   Both the ZooKeeper-based and KRaft brokers invoke `KafkaScheduler.shutdown()` too early -- before `LogManager.shutdown()` is invoked.  So it is possible for `LogManager` to try to use the scheduler after the scheduler has been shutdown, which results in an exception.  This patch moves the shutdown of the scheduler to a point after the shutdown of `LogManager`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe merged pull request #10538: MINOR: shutdown KafkaScheduler at appropriate time

Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #10538:
URL: https://github.com/apache/kafka/pull/10538


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on a change in pull request #10538: MINOR: shutdown KafkaScheduler at appropriate time

Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #10538:
URL: https://github.com/apache/kafka/pull/10538#discussion_r613610409



##########
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##########
@@ -453,6 +451,8 @@ class BrokerServer(
 
       if (logManager != null)
         CoreUtils.swallow(logManager.shutdown(), this)
+      if (kafkaScheduler != null)

Review comment:
       Can we add a comment here and in KafkaServer?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org