You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/23 09:57:19 UTC
[GitHub] [incubator-nuttx] chengkai15 opened a new pull request, #6900: wireless/bluetooth:add btsnoop open-close ioctl cmd
chengkai15 opened a new pull request, #6900:
URL: https://github.com/apache/incubator-nuttx/pull/6900
1. SIOCBTSNOOPOPEN: open btsnoop
2. SIOCBTSNOOPCLOSE: close btsnoop
Signed-off-by: chengkai <ch...@xiaomi.com>
## Summary
add btsnoop control cmd
1. SIOCBTSNOOPOPEN: open btsnoop
2. SIOCBTSNOOPCLOSE: close btsnoop
## Impact
## Testing
pass ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] chengkai15 commented on a diff in pull request #6900: wireless/bluetooth:add btsnoop open-close ioctl cmd
Posted by GitBox <gi...@apache.org>.
chengkai15 commented on code in PR #6900:
URL: https://github.com/apache/incubator-nuttx/pull/6900#discussion_r953269573
##########
include/nuttx/wireless/bluetooth/bt_ioctl.h:
##########
@@ -61,9 +61,13 @@
#define HCI_GATTRD_DATA 32 /* Max number of bytes in GATT read data */
#define HCI_GATTWR_DATA 16 /* Max number of bytes in GATT write data */
+#ifndef CONFIG_BLUETOOTH_MAXSCANDATA
Review Comment:
if user just do btsnoop open/close ioctl without any wireless bluetooth host operation， which would BB in line:297.
because BLUETOOTH_MAXSCANDATA depends on WIRELESS_BLUETOOTH_HOST，which would expand many unused config.
struct bt_scanresponse_s
{
bt_addr_le_t sr_addr; /* Advertiser LE address and type */
int8_t sr_rssi; /* Strength of advertiser signal */
uint8_t sr_type; /* Type of advertising response */
uint8_t sr_len; /* Length of advertiser data */
uint8_t sr_data[CONFIG_BLUETOOTH_MAXSCANDATA];
};
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6900: wireless/bluetooth:add btsnoop open-close ioctl cmd
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6900:
URL: https://github.com/apache/incubator-nuttx/pull/6900#discussion_r953272516
##########
include/nuttx/wireless/bluetooth/bt_ioctl.h:
##########
@@ -61,9 +61,13 @@
#define HCI_GATTRD_DATA 32 /* Max number of bytes in GATT read data */
#define HCI_GATTWR_DATA 16 /* Max number of bytes in GATT write data */
+#ifndef CONFIG_BLUETOOTH_MAXSCANDATA
Review Comment:
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6900: wireless/bluetooth:add btsnoop open-close ioctl cmd
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6900:
URL: https://github.com/apache/incubator-nuttx/pull/6900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] chengkai15 commented on pull request #6900: wireless/bluetooth:add btsnoop open-close ioctl cmd
Posted by GitBox <gi...@apache.org>.
chengkai15 commented on PR #6900:
URL: https://github.com/apache/incubator-nuttx/pull/6900#issuecomment-1225125169
> @chengkai15 are you using the btsnoop from Android or is this a home-brew implementation?
This is just a home-brew implementation，which would support some other snoop except btsnoop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6900: wireless/bluetooth:add btsnoop open-close ioctl cmd
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6900:
URL: https://github.com/apache/incubator-nuttx/pull/6900#discussion_r952425588
##########
include/nuttx/wireless/bluetooth/bt_ioctl.h:
##########
@@ -61,9 +61,13 @@
#define HCI_GATTRD_DATA 32 /* Max number of bytes in GATT read data */
#define HCI_GATTWR_DATA 16 /* Max number of bytes in GATT write data */
+#ifndef CONFIG_BLUETOOTH_MAXSCANDATA
Review Comment:
Why add this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6900: wireless/bluetooth:add btsnoop open-close ioctl cmd
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #6900:
URL: https://github.com/apache/incubator-nuttx/pull/6900#issuecomment-1223983072
@chengkai15 are you using the btsnoop from Android or is this a home-brew implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org