You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/21 20:58:15 UTC
[GitHub] [incubator-pekko-connectors-kafka] pjfanning opened a new pull request, #73: fix up note about naming
pjfanning opened a new pull request, #73:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/73
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on a diff in pull request #73: fix up note about naming
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #73:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/73#discussion_r1200565637
##########
project/plugins.sbt:
##########
@@ -15,14 +15,6 @@ addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")
resolvers += Resolver.jcenterRepo
// allow access to snapshots for pekko-sbt-paradox
-resolvers += "Apache Nexus Snapshots".at("https://repository.apache.org/content/repositories/snapshots/")
+resolvers += Resolver.ApacheMavenSnapshotsRepo
-// We have to deliberately use older versions of sbt-paradox because current Pekko sbt build
-// only loads on JDK 1.8 so we need to bring in older versions of parboiled which support JDK 1.8
-addSbtPlugin(("org.apache.pekko" % "pekko-sbt-paradox" % "0.0.0+19-f498f7c0-SNAPSHOT").excludeAll(
Review Comment:
thanks - brought back the excludeAll - for some reason I thought we might have fixed the need for that on our in pekko-sbt-paradox
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning merged pull request #73: fix up note about naming
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #73:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] mdedetrich commented on a diff in pull request #73: fix up note about naming
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #73:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/73#discussion_r1200466908
##########
project/plugins.sbt:
##########
@@ -15,14 +15,6 @@ addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")
resolvers += Resolver.jcenterRepo
// allow access to snapshots for pekko-sbt-paradox
-resolvers += "Apache Nexus Snapshots".at("https://repository.apache.org/content/repositories/snapshots/")
+resolvers += Resolver.ApacheMavenSnapshotsRepo
-// We have to deliberately use older versions of sbt-paradox because current Pekko sbt build
-// only loads on JDK 1.8 so we need to bring in older versions of parboiled which support JDK 1.8
-addSbtPlugin(("org.apache.pekko" % "pekko-sbt-paradox" % "0.0.0+19-f498f7c0-SNAPSHOT").excludeAll(
Review Comment:
Can we undo the JDK 1.8 workaround? I think this will break publishing because currently publishing (which includes making docs) is done under JDK 8 (see https://github.com/apache/incubator-pekko-connectors-kafka/blob/main/.github/workflows/publish-nightly.yml#L39-L43) and removing this workaround would cause paradox doc generation to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] mdedetrich commented on a diff in pull request #73: fix up note about naming
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #73:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/73#discussion_r1200466908
##########
project/plugins.sbt:
##########
@@ -15,14 +15,6 @@ addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")
resolvers += Resolver.jcenterRepo
// allow access to snapshots for pekko-sbt-paradox
-resolvers += "Apache Nexus Snapshots".at("https://repository.apache.org/content/repositories/snapshots/")
+resolvers += Resolver.ApacheMavenSnapshotsRepo
-// We have to deliberately use older versions of sbt-paradox because current Pekko sbt build
-// only loads on JDK 1.8 so we need to bring in older versions of parboiled which support JDK 1.8
-addSbtPlugin(("org.apache.pekko" % "pekko-sbt-paradox" % "0.0.0+19-f498f7c0-SNAPSHOT").excludeAll(
Review Comment:
Can we undo the JDK 1.8 workaround removal? I think this will break publishing because currently publishing (which includes making docs) is done under JDK 8 (see https://github.com/apache/incubator-pekko-connectors-kafka/blob/main/.github/workflows/publish-nightly.yml#L39-L43) and removing this workaround would cause paradox doc generation to fail when running under JDK 8.
Bumping snapshot version is of course fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] mdedetrich commented on a diff in pull request #73: fix up note about naming
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #73:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/73#discussion_r1200466908
##########
project/plugins.sbt:
##########
@@ -15,14 +15,6 @@ addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")
resolvers += Resolver.jcenterRepo
// allow access to snapshots for pekko-sbt-paradox
-resolvers += "Apache Nexus Snapshots".at("https://repository.apache.org/content/repositories/snapshots/")
+resolvers += Resolver.ApacheMavenSnapshotsRepo
-// We have to deliberately use older versions of sbt-paradox because current Pekko sbt build
-// only loads on JDK 1.8 so we need to bring in older versions of parboiled which support JDK 1.8
-addSbtPlugin(("org.apache.pekko" % "pekko-sbt-paradox" % "0.0.0+19-f498f7c0-SNAPSHOT").excludeAll(
Review Comment:
Can we undo the JDK 1.8 workaround removal? I think this will break publishing because currently publishing (which includes making docs) is done under JDK 8 (see https://github.com/apache/incubator-pekko-connectors-kafka/blob/main/.github/workflows/publish-nightly.yml#L39-L43) and removing this workaround would cause paradox doc generation to fail.
Bumping snapshot version is of course fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org