[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14095: Optimize move semantics of NodeEntry

[GitBox <gi...@apache.org>]

apeforest commented on a change in pull request #14095: Optimize move semantics of NodeEntry
URL: https://github.com/apache/incubator-mxnet/pull/14095#discussion_r284793210
 
 

 ##########
 File path: src/executor/infer_graph_attr_pass.cc
 ##########
 @@ -628,7 +628,8 @@ nnvm::Graph InferShapeAttr(nnvm::Graph &&ret,
     }
     if (dispatch_mode_name) {
       for (size_t i = node_start; i < node_end; i++) {
-        if (dispatch_modes[i] == DispatchMode::kUndefined) ++num_unknown;
+        if (dispatch_modes[i] == DispatchMode::kUndefined)
 
 Review comment:
   nit: add braces around if block.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services