You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Leon (JIRA)" <ji...@apache.org> on 2011/08/29 18:34:37 UTC
[jira] [Created] (OFBIZ-4380) improve the behavior of nested lookup
dialogs (ajax mode)
improve the behavior of nested lookup dialogs (ajax mode)
----------------------------------------------------------
Key: OFBIZ-4380
URL: https://issues.apache.org/jira/browse/OFBIZ-4380
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Reporter: Leon
Priority: Minor
Fix For: SVN trunk
Attachments: fieldlookup.js
nested lookup dialogs: in one lookup dialog, it opens another lookup dialog.
trivial improvements:
1. "enter" event only occurs to lookup dialog itself
2. if mouse click out side the lookup dialog, only current activated dialog closes
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4380) improve the behavior of nested
lookup dialogs (ajax mode)
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093467#comment-13093467 ]
Jacques Le Roux commented on OFBIZ-4380:
----------------------------------------
BTW I saw you code was good and relevant in the review, that's why I asked for some help, appreciated... Good work !
> improve the behavior of nested lookup dialogs (ajax mode)
> ----------------------------------------------------------
>
> Key: OFBIZ-4380
> URL: https://issues.apache.org/jira/browse/OFBIZ-4380
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4380-fieldlookup.js.patch
>
>
> nested lookup dialogs: in one lookup dialog, it opens another lookup dialog.
> trivial improvements:
> 1. "enter" event only occurs to lookup dialog itself
> 2. if mouse click out side the lookup dialog, only current activated dialog closes
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4380) improve the behavior of nested
lookup dialogs (ajax mode)
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093250#comment-13093250 ]
Jacques Le Roux commented on OFBIZ-4380:
----------------------------------------
Also please use .patch as suffix for your patches. For isntance, a name like OFBIZ-4380-fieldlookup.js.patch would be appreciated. (or even OFBIZ-4380-improve the behavior of nested lookup dialogs in ajax mode.patch)
> improve the behavior of nested lookup dialogs (ajax mode)
> ----------------------------------------------------------
>
> Key: OFBIZ-4380
> URL: https://issues.apache.org/jira/browse/OFBIZ-4380
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: fieldlookup.js
>
>
> nested lookup dialogs: in one lookup dialog, it opens another lookup dialog.
> trivial improvements:
> 1. "enter" event only occurs to lookup dialog itself
> 2. if mouse click out side the lookup dialog, only current activated dialog closes
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4380) improve the behavior of nested lookup
dialogs (ajax mode)
Posted by "Leon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leon updated OFBIZ-4380:
------------------------
Attachment: fieldlookup.js
> improve the behavior of nested lookup dialogs (ajax mode)
> ----------------------------------------------------------
>
> Key: OFBIZ-4380
> URL: https://issues.apache.org/jira/browse/OFBIZ-4380
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: fieldlookup.js
>
>
> nested lookup dialogs: in one lookup dialog, it opens another lookup dialog.
> trivial improvements:
> 1. "enter" event only occurs to lookup dialog itself
> 2. if mouse click out side the lookup dialog, only current activated dialog closes
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4380) improve the behavior of nested lookup
dialogs (ajax mode)
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-4380.
----------------------------------
Resolution: Fixed
Fix Version/s: Release Branch 11.04
Assignee: Jacques Le Roux
Thanks for the explanation Leon!
It was late and I really needed some help ;)
Your patch is in
trunk r1163093
R11.04 r1163095
> improve the behavior of nested lookup dialogs (ajax mode)
> ----------------------------------------------------------
>
> Key: OFBIZ-4380
> URL: https://issues.apache.org/jira/browse/OFBIZ-4380
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4380-fieldlookup.js.patch
>
>
> nested lookup dialogs: in one lookup dialog, it opens another lookup dialog.
> trivial improvements:
> 1. "enter" event only occurs to lookup dialog itself
> 2. if mouse click out side the lookup dialog, only current activated dialog closes
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4380) improve the behavior of nested lookup
dialogs (ajax mode)
Posted by "Leon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leon updated OFBIZ-4380:
------------------------
Attachment: (was: fieldlookup.js)
> improve the behavior of nested lookup dialogs (ajax mode)
> ----------------------------------------------------------
>
> Key: OFBIZ-4380
> URL: https://issues.apache.org/jira/browse/OFBIZ-4380
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Priority: Minor
> Fix For: SVN trunk
>
>
> nested lookup dialogs: in one lookup dialog, it opens another lookup dialog.
> trivial improvements:
> 1. "enter" event only occurs to lookup dialog itself
> 2. if mouse click out side the lookup dialog, only current activated dialog closes
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4380) improve the behavior of nested
lookup dialogs (ajax mode)
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093242#comment-13093242 ]
Jacques Le Roux commented on OFBIZ-4380:
----------------------------------------
Sorry Leon, but I don't see much differences. Before applying your patch Enter is already working in the last layered lookup and with your change when clicking outside the last layered lookup all the layered lookups are closed. Maybe I'm missing something, could you explain?
> improve the behavior of nested lookup dialogs (ajax mode)
> ----------------------------------------------------------
>
> Key: OFBIZ-4380
> URL: https://issues.apache.org/jira/browse/OFBIZ-4380
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: fieldlookup.js
>
>
> nested lookup dialogs: in one lookup dialog, it opens another lookup dialog.
> trivial improvements:
> 1. "enter" event only occurs to lookup dialog itself
> 2. if mouse click out side the lookup dialog, only current activated dialog closes
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4380) improve the behavior of nested
lookup dialogs (ajax mode)
Posted by "Leon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093401#comment-13093401 ]
Leon commented on OFBIZ-4380:
-----------------------------
1. You can put an alert("blah...") sentence into "lookup_onKeyEnter" function, then you will find that this function is called multi times if there're multi lookup dialog opened. In some situation, e.g. slow network speed, messed execute sequence of multi bound "keypress" function to html.document, you will get the wrong lookup page in your last layered dialog.
2. Maybe Ctrl+F5 needed to reload the js.
Technically, as per the original sentence jQuery(".ui-widget-overlay").live("click", function() { jQuery("#" + lookupId).dialog("close"); } );, it finds all div which has "ui-widget-overlay" classname and trigger "click" event for each of them, consequently, it will close all lookup dialog. Besides that, since the framework creates "ui-widget-overlay" div for each lookup field, that means, if there're 100 lookup fields in a page, then the "click" event will be trigger 100 times.
> improve the behavior of nested lookup dialogs (ajax mode)
> ----------------------------------------------------------
>
> Key: OFBIZ-4380
> URL: https://issues.apache.org/jira/browse/OFBIZ-4380
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4380-fieldlookup.js.patch
>
>
> nested lookup dialogs: in one lookup dialog, it opens another lookup dialog.
> trivial improvements:
> 1. "enter" event only occurs to lookup dialog itself
> 2. if mouse click out side the lookup dialog, only current activated dialog closes
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4380) improve the behavior of nested lookup
dialogs (ajax mode)
Posted by "Leon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leon updated OFBIZ-4380:
------------------------
Attachment: OFBIZ-4380-fieldlookup.js.patch
> improve the behavior of nested lookup dialogs (ajax mode)
> ----------------------------------------------------------
>
> Key: OFBIZ-4380
> URL: https://issues.apache.org/jira/browse/OFBIZ-4380
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4380-fieldlookup.js.patch
>
>
> nested lookup dialogs: in one lookup dialog, it opens another lookup dialog.
> trivial improvements:
> 1. "enter" event only occurs to lookup dialog itself
> 2. if mouse click out side the lookup dialog, only current activated dialog closes
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira