You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/01/20 14:49:45 UTC
Review Request 55766: Fixed body padding in mobile WebUI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55766/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and haosdent huang.
Bugs: MESOS-6962
https://issues.apache.org/jira/browse/MESOS-6962
Repository: mesos
Description
-------
Body top padding is always required when the navbar is fixed to top.
http://getbootstrap.com/components/#navbar-fixed-top
Diffs
-----
src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
Diff: https://reviews.apache.org/r/55766/diff/
Testing
-------
Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1.
Thanks,
Ilya Pronin
Re: Review Request 55766: Fixed body padding in mobile WebUI.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55766/#review162427
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Jan. 20, 2017, 2:49 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55766/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 2:49 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6962
> https://issues.apache.org/jira/browse/MESOS-6962
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Body top padding is always required when the navbar is fixed to top.
> http://getbootstrap.com/components/#navbar-fixed-top
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
>
> Diff: https://reviews.apache.org/r/55766/diff/
>
>
> Testing
> -------
>
> Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 55766: Fixed body padding in mobile WebUI.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55766/#review162507
-----------------------------------------------------------
Bad patch!
Reviews applied: [55766]
Failed command: python support/apply-reviews.py -n -r 55766
Error:
2017-01-20 21:48:08 URL:https://reviews.apache.org/r/55766/diff/raw/ [674/674] -> "55766.patch" [1]
error: patch failed: src/webui/master/static/css/mesos.css:45
error: src/webui/master/static/css/mesos.css: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/16795/console
- Mesos Reviewbot
On Jan. 20, 2017, 2:49 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55766/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2017, 2:49 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and haosdent huang.
>
>
> Bugs: MESOS-6962
> https://issues.apache.org/jira/browse/MESOS-6962
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Body top padding is always required when the navbar is fixed to top.
> http://getbootstrap.com/components/#navbar-fixed-top
>
>
> Diffs
> -----
>
> src/webui/master/static/css/mesos.css c817aaee0fd2d2579ff2e4a152d47e83ce80d68c
>
> Diff: https://reviews.apache.org/r/55766/diff/
>
>
> Testing
> -------
>
> Tested in Safari 10.0.2, Chrome 55 and Firefox 50.1.
>
>
> Thanks,
>
> Ilya Pronin
>
>