You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Robert Burrell Donkin <ro...@gmail.com> on 2008/10/27 22:02:09 UTC
[jsieve] Samples Module Worthwhile?
i've been taking a look at completing some of the changes required to
make jsieve into a multi-module project
(http://svn.apache.org/repos/asf/james/jsieve/trunk/).
the original plan was to separate out the code in src/samples into a
separate module. the source in there contains samples plus
ScriptChecker - a useful utility for verifying sieve scripts. this
doesn't really make sense as a samples module so i created a util
module and moved it into there.
however, having taken a look at the remaining samples code, i see that
they are just an example mailet. given that we have a better mailet in
james server which will (hopefully) sometime soon be moved into jsieve
as a module, i wonder whether it would be better just to delete the
sample rather than try to update it.
opinions?
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jsieve] Samples Module Worthwhile?
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Fri, Oct 31, 2008 at 8:27 AM, Stefano Bagnara <ap...@bago.org> wrote:
> Robert Burrell Donkin ha scritto:
>> i've been taking a look at completing some of the changes required to
>> make jsieve into a multi-module project
>> (http://svn.apache.org/repos/asf/james/jsieve/trunk/).
>>
>> the original plan was to separate out the code in src/samples into a
>> separate module. the source in there contains samples plus
>> ScriptChecker - a useful utility for verifying sieve scripts. this
>> doesn't really make sense as a samples module so i created a util
>> module and moved it into there.
>
> No time to check the sources now, but if ScriptChecker does not
> introduce dependencies (or if can make them optional) and we don't plan
> to add more stuff to "util" it could be moved to the main library
> module. No need to have an util module for a single class otherwise.
it's couple of classes but it introduces additional dependencies. it's
possible that the xml stuff currently being discussed will also
introduce dependencies.
i'd prefer to leave the util module for now and see whether it
accumulates anything else. we can review again before the next
release.
>> however, having taken a look at the remaining samples code, i see that
>> they are just an example mailet. given that we have a better mailet in
>> james server which will (hopefully) sometime soon be moved into jsieve
>> as a module, i wonder whether it would be better just to delete the
>> sample rather than try to update it.
>>
>> opinions?
>
> works for me!
ok
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jsieve] Samples Module Worthwhile?
Posted by Stefano Bagnara <ap...@bago.org>.
Robert Burrell Donkin ha scritto:
> i've been taking a look at completing some of the changes required to
> make jsieve into a multi-module project
> (http://svn.apache.org/repos/asf/james/jsieve/trunk/).
>
> the original plan was to separate out the code in src/samples into a
> separate module. the source in there contains samples plus
> ScriptChecker - a useful utility for verifying sieve scripts. this
> doesn't really make sense as a samples module so i created a util
> module and moved it into there.
No time to check the sources now, but if ScriptChecker does not
introduce dependencies (or if can make them optional) and we don't plan
to add more stuff to "util" it could be moved to the main library
module. No need to have an util module for a single class otherwise.
> however, having taken a look at the remaining samples code, i see that
> they are just an example mailet. given that we have a better mailet in
> james server which will (hopefully) sometime soon be moved into jsieve
> as a module, i wonder whether it would be better just to delete the
> sample rather than try to update it.
>
> opinions?
works for me!
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org