[jira] Issue Comment Edited: (BUILDR-449) Fix failing specs on Windows

["Pepijn Van Eeckhoudt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BUILDR-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874567#action_12874567 ] 

Pepijn Van Eeckhoudt edited comment on BUILDR-449 at 6/2/10 8:47 AM:
---------------------------------------------------------------------

After some further investigation I've backtracked on my first fix attempt. I had assumed that utime to a time in the past was not working but in actuality it was utime on directories that was simply not working at all. I patched JRuby to fix this and have restarted my testing effort from scratch.

I first wrote some specs to check that utime works on files, directories, in the past and in the future. Once those were working I reran all the specs and hooray most of them worked immediately.

I've fixed a number of misc other things to get the remaining failing ones to work:
- Disabled ZipTask:'should preserve file permissions' on windows as this cannot be implemented correctly yet.
- Added URI.escape() around all file:// URLs in the specs to make sure directories with spaces are handled correctly
- Patched FILE#real_path to return an unescaped version of the path so that we don't get %20 directories on the local FS
- Allowed mode flags to be passed to Buildr#read. Due to CRLF to LF conversion the signature validation spec was failing. This spec now uses 'rb' as mode flags 

spec_fixes2.patch includes all this stuff and supersedes the previous patch (spec_fixes.patch). This is dependent on JRUBY-4837.

      was (Author: pepijnve):
    After some further investigation I've backtracked on my first fix attempt. I had assumed that utime to a time in the past was not working but in actuality it was utime on directories that was simply not working at all. I patched JRuby to fix this and have restarted my testing effort from scratch.

I first wrote some specs to check that utime works on files, directories, in the past and in the future. Once those were working I reran all the specs and hooray most of them worked immediately.

I've fixed a number of misc other things to get the remaining failing ones to work:
- Disabled ZipTask:'should preserve file permissions' on windows as this cannot be implemented correctly yet.
- Added URI.escape() around all file:// URLs in the specs to make sure directories with spaces are handled correctly
- Patched FILE#real_path to return an unescaped version of the path so that we don't get %20 directories on the local FS
- Allowed mode flags to be passed to Buildr#read. Due to CRLF to LF conversion the signature validation spec was failing. This spec now uses 'rb' as mode flags 

spec_fixes2.patch includes all this stuff and supersedes the previous patch (spec_fixes.patch)
  
> Fix failing specs on Windows
> ----------------------------
>
>                 Key: BUILDR-449
>                 URL: https://issues.apache.org/jira/browse/BUILDR-449
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Core features
>    Affects Versions: 1.4
>            Reporter: Pepijn Van Eeckhoudt
>            Assignee: Antoine Toulme
>             Fix For: 1.4
>
>         Attachments: spec_fixes.patch, spec_fixes2.patch
>
>
> The attached spec resolves a number of failing specs on Windows. These fixes have not yet been tested on other platforms.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.