You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "simhadri-g (via GitHub)" <gi...@apache.org> on 2023/04/26 21:54:34 UTC
[GitHub] [hive] simhadri-g opened a new pull request, #4274: HIVE-27277: GH actions to build and push docker image
simhadri-g opened a new pull request, #4274:
URL: https://github.com/apache/hive/pull/4274
Hi Everyone,
I have got the docker hub repository setup for Apache hive from Infra.
https://issues.apache.org/jira/browse/INFRA-24505
DockerHub: https://hub.docker.com/r/apache/hive
In order to publish the docker image to Docker hub, in this PR I have set up GitHub actions workflow to build and push docker image to Docker hub. The workflow was tested on a hive fork and the image was successfully pushed here. https://hub.docker.com/repository/docker/simhadri064/hive/tags?page=1&ordering=last_updated
We will need to decide on the frequency at which we push these images to docker hub.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Set up the same workflow on why fork and pushed to personal dockerhub account via github actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] simhadri-g closed pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "simhadri-g (via GitHub)" <gi...@apache.org>.
simhadri-g closed pull request #4274: HIVE-27277: GH actions to build and push docker image
URL: https://github.com/apache/hive/pull/4274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] simhadri-g commented on pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "simhadri-g (via GitHub)" <gi...@apache.org>.
simhadri-g commented on PR #4274:
URL: https://github.com/apache/hive/pull/4274#issuecomment-1535334329
Will reopen the PR after testing with new changes completes. This is to prevent unnecessary runs of hive precommit tests .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1178601057
##########
packaging/src/docker/Dockerfile:
##########
@@ -14,14 +14,31 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+ARG BUILD_ENV
+
FROM ubuntu as unarchive
Review Comment:
Cloud you please add ARG `BUILD_ENV=unarchive` to the `build.sh`:
https://github.com/apache/hive/blob/master/packaging/src/docker/build.sh#L115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] simhadri-g commented on a diff in pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "simhadri-g (via GitHub)" <gi...@apache.org>.
simhadri-g commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1180027342
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,38 @@
+name: ci hive docker image
+
+on:
+ push:
+ branches:
+ - "master"
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ -
+ name: Checkout
+ uses: actions/checkout@v3
+ -
+ name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USERNAME }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ -
+ name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v2
+
+ -
+ name: Build and push
+ uses: docker/build-push-action@v4
+ with:
+ context: ./packaging/src/docker/
+ file: ./packaging/src/docker/Dockerfile
+ push: true
+ tags: ${{ secrets.DOCKERHUB_USERNAME }}/hive:test-image
Review Comment:
> Can we trigger the build for GA automatically?
>https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
Since we are pushing the changes to the dockerhub for the 1st time, we wanted to trigger it with workflow_dispatcher to verify the dockerhub integration.
Once we verify that this GH action succeeds, we can set it to trigger automatically and update all the images on every release or once every three months.
> I think it makes some troubles every time we should add the new GA build manually, it adds extra steps for
> releasing the new version, sometimes we may even forget about it.
I agree, but I think for a new GA :
- We will not have prior knowledge of the versions of hive, tez and hadoop to use in the next GA. (Workaround could be: obtain from pom.xml)
- Someone will have to build the new GA docker images locally and verify if it's working before we push them to docker hub.
So that is why i was thinking we should retain the manual step at release time.
Other repos follow something similar: https://github.com/apache/spark-docker/tree/master/.github/workflows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] TuroczyX commented on a diff in pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "TuroczyX (via GitHub)" <gi...@apache.org>.
TuroczyX commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1178832352
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,38 @@
+name: ci hive docker image
+
+on:
+ push:
Review Comment:
I think we should have a -latest with the GA version.
Also we could have a daily release about the -dev version (or tags)
for every commit would be a bit overused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] TuroczyX commented on a diff in pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "TuroczyX (via GitHub)" <gi...@apache.org>.
TuroczyX commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1178833962
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,38 @@
+name: ci hive docker image
+
+on:
+ push:
+ branches:
+ - "master"
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ -
+ name: Checkout
+ uses: actions/checkout@v3
+ -
+ name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USERNAME }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ -
+ name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v2
+
+ -
+ name: Build and push
+ uses: docker/build-push-action@v4
+ with:
+ context: ./packaging/src/docker/
+ file: ./packaging/src/docker/Dockerfile
+ push: true
+ tags: ${{ secrets.DOCKERHUB_USERNAME }}/hive:test-image
Review Comment:
How about -hive:dev or -hive:daily?
The GA version should be the same as the industry follows like hive4.0-latest imho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1178592897
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,38 @@
+name: ci hive docker image
+
+on:
+ push:
Review Comment:
Some thoughts on the frequency:
1. We would better to trigger the action for every new release.
2. For master branch, I think we can update the image every three months.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1179811798
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,38 @@
+name: ci hive docker image
+
+on:
+ push:
Review Comment:
Once per week makes sense to me for dev, if there are some limitations on the number of the dev images, for example, only keep the latest 10 images for dev.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] simhadri-g commented on pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "simhadri-g (via GitHub)" <gi...@apache.org>.
simhadri-g commented on PR #4274:
URL: https://github.com/apache/hive/pull/4274#issuecomment-1536172471
New PR:
https://github.com/apache/hive/pull/4298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] simhadri-g commented on pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "simhadri-g (via GitHub)" <gi...@apache.org>.
simhadri-g commented on PR #4274:
URL: https://github.com/apache/hive/pull/4274#issuecomment-1527432471
Since we are pushing the changes to the docker hub for the 1st time, we wanted to trigger it with workflow_dispatcher to verify the docker hub integration.
Once we verify that this GH action succeeds, I would like to parameterize this and we can set it to trigger automatically every release when a new rel/**-<version> branch gets created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] simhadri-g commented on a diff in pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "simhadri-g (via GitHub)" <gi...@apache.org>.
simhadri-g commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1179117576
##########
packaging/src/docker/Dockerfile:
##########
@@ -14,14 +14,31 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+ARG BUILD_ENV
+
FROM ubuntu as unarchive
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on PR #4274:
URL: https://github.com/apache/hive/pull/4274#issuecomment-1527273600
@zabetak / @abstractdog / @dengzhhu653 any comments/thoughts on this. @simhadri-g has a planned follow up as well on this, he can share the details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4274:
URL: https://github.com/apache/hive/pull/4274#issuecomment-1526848550
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4274)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4274&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4274&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4274&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=CODE_SMELL) [16 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4274&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4274&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1178599606
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,38 @@
+name: ci hive docker image
+
+on:
+ push:
+ branches:
+ - "master"
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ -
+ name: Checkout
+ uses: actions/checkout@v3
+ -
+ name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USERNAME }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ -
+ name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v2
+
+ -
+ name: Build and push
+ uses: docker/build-push-action@v4
+ with:
+ context: ./packaging/src/docker/
+ file: ./packaging/src/docker/Dockerfile
+ push: true
+ tags: ${{ secrets.DOCKERHUB_USERNAME }}/hive:test-image
Review Comment:
We'd better add the real version to the image instead of `test-image`, and I'm thinking it would be great if we can determine the `HADOOP_VERSION`, `TEZ_VERSION` from the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a diff in pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "dengzhhu653 (via GitHub)" <gi...@apache.org>.
dengzhhu653 commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1179810363
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,38 @@
+name: ci hive docker image
+
+on:
+ push:
+ branches:
+ - "master"
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ -
+ name: Checkout
+ uses: actions/checkout@v3
+ -
+ name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USERNAME }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ -
+ name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v2
+
+ -
+ name: Build and push
+ uses: docker/build-push-action@v4
+ with:
+ context: ./packaging/src/docker/
+ file: ./packaging/src/docker/Dockerfile
+ push: true
+ tags: ${{ secrets.DOCKERHUB_USERNAME }}/hive:test-image
Review Comment:
Can we trigger the build for GA automatically?
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
I think it makes some troubles every time we should add the new GA build manually, it adds extra steps for releasing the new version, sometimes we may even forget about it.
For the old released version, I think we can push the image manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] simhadri-g commented on a diff in pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "simhadri-g (via GitHub)" <gi...@apache.org>.
simhadri-g commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1180027342
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,38 @@
+name: ci hive docker image
+
+on:
+ push:
+ branches:
+ - "master"
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ -
+ name: Checkout
+ uses: actions/checkout@v3
+ -
+ name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USERNAME }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ -
+ name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v2
+
+ -
+ name: Build and push
+ uses: docker/build-push-action@v4
+ with:
+ context: ./packaging/src/docker/
+ file: ./packaging/src/docker/Dockerfile
+ push: true
+ tags: ${{ secrets.DOCKERHUB_USERNAME }}/hive:test-image
Review Comment:
> Can we trigger the build for GA automatically?
>https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
Since we are pushing the changes to the dockerhub for the 1st time, we wanted to trigger it with workflow_dispatcher to verify the dickerhub integration.
Once we verify that this GH action succeeds, we can set it to trigger automatically and update all the images on every release or once every three months.
> I think it makes some troubles every time we should add the new GA build manually, it adds extra steps for
> releasing the new version, sometimes we may even forget about it.
I agree, but I think for a new GA :
- We will not have prior knowledge of the versions of hive, tez and hadoop to use in the next GA. (Workaround could be: obtain from pom.xml)
- Someone will have to build the new GA docker images locally and verify if it's working before we push them to docker hub.
So that is why i was thinking we should retain the manual step at release time.
Other repos follow something similar: https://github.com/apache/spark-docker/tree/master/.github/workflows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4274:
URL: https://github.com/apache/hive/pull/4274#issuecomment-1524669646
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4274)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4274&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4274&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4274&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4274&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4274&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4274&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] simhadri-g commented on a diff in pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "simhadri-g (via GitHub)" <gi...@apache.org>.
simhadri-g commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1179136508
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,38 @@
+name: ci hive docker image
+
+on:
+ push:
+ branches:
+ - "master"
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ -
+ name: Checkout
+ uses: actions/checkout@v3
+ -
+ name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USERNAME }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ -
+ name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v2
+
+ -
+ name: Build and push
+ uses: docker/build-push-action@v4
+ with:
+ context: ./packaging/src/docker/
+ file: ./packaging/src/docker/Dockerfile
+ push: true
+ tags: ${{ secrets.DOCKERHUB_USERNAME }}/hive:test-image
Review Comment:
For GA: the versions that are set in the .yml file were manually configured after looking at the hive/pom.xml file.
For hive:daily, i think we can obtain them from the pom.xml file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] simhadri-g commented on a diff in pull request #4274: HIVE-27277: GH actions to build and push docker image
Posted by "simhadri-g (via GitHub)" <gi...@apache.org>.
simhadri-g commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1179135961
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,38 @@
+name: ci hive docker image
+
+on:
+ push:
Review Comment:
I think we should have 2 workflows:
1. GA workflow - Frequency : Once per release
2. For the latest dev images. - Frequency: Once per week? Because on an average hive gets about 10 to 15 commits per week.(https://github.com/apache/hive/graphs/commit-activity)
This PR set up a workflow to build and publish docker images for the GA versions of hive.
I will raise a follow-up jira to address the workflow needed for daily/dev images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org