You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/06 20:57:32 UTC
[GitHub] [airflow] kaxil opened a new pull request #12862: Bugfix: Entrypoint Import Exception masked by attribute error
kaxil opened a new pull request #12862:
URL: https://github.com/apache/airflow/pull/12862
`entry_point.module_name` -- Entrypoint does not have a `module_name`
attribute.
This commit also makes importlib_metadata conditional as it is not
needed for Py 3.9
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12862: Bugfix: Entrypoint Import Exception masked by attribute error
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12862:
URL: https://github.com/apache/airflow/pull/12862#issuecomment-739883661
"Python unit tests for helm chart" is failing on Upload code coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #12862: Bugfix: Entrypoint Import Exception masked by attribute error
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12862:
URL: https://github.com/apache/airflow/pull/12862#discussion_r537463597
##########
File path: tests/plugins/test_plugins_manager.py
##########
@@ -24,6 +25,9 @@
from airflow.www import app as application
from tests.test_utils.mock_plugins import mock_plugin_manager
+py39 = sys.version_info[0:2] >= (3, 9)
Review comment:
```suggestion
py39 = sys.version_info >= (3, 9)
```
##########
File path: tests/plugins/test_plugins_manager.py
##########
@@ -24,6 +25,9 @@
from airflow.www import app as application
from tests.test_utils.mock_plugins import mock_plugin_manager
+py39 = sys.version_info[0:2] >= (3, 9)
Review comment:
And lets make it PY39
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #12862: Bugfix: Entrypoint Import Exception masked by attribute error
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12862:
URL: https://github.com/apache/airflow/pull/12862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org