You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/05/21 23:22:47 UTC

[GitHub] [thrift] Jens-G commented on pull request #2121: THRIFT-5185: Add support for using WebSockets as a server transport.

Jens-G commented on pull request #2121:
URL: https://github.com/apache/thrift/pull/2121#issuecomment-632394608


   > Could that be used instead? 
   
   I had the same thoughs ... we have code for it. Should'nt that be sufficient?
   
   > he definition of 'htonll' breaks the build for me
   
   Actually, on the Github page of said header, someone also commented that MSVC seems not really good covered by it, at least this was the case in 2018. 
   
   https://gist.github.com/panzi/6856583#gistcomment-2396000
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org