You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2023/04/24 08:50:37 UTC
[GitHub] [doris] Mryange opened a new pull request, #19001: [fix](function) Support more behaviors of cast time in MySQL.
Mryange opened a new pull request, #19001:
URL: https://github.com/apache/doris/pull/19001
# Proposed changes
**before**
```
mysql [(none)]>select cast('2023-02-02 19:18:17' as time);
+-------------------------------------+
| CAST('2023-02-02 19:18:17' AS TIME) |
+-------------------------------------+
| NULL |
+-------------------------------------+
```
**affter**
```
mysql [(none)]>select cast('2023-02-02 19:18:17' as time);
+-------------------------------------+
| CAST('2023-02-02 19:18:17' AS TIME) |
+-------------------------------------+
| 19:18:17 |
+-------------------------------------+
```
## Problem summary
In the past, the "time" type was stored using double, but later additional date types were added. The problem is that we do not allow users to use the "time" type
```
ERROR 1105 (HY000): errCode = 2, detailMessage = Unsupported type: TIME
```
it is only used internally in the program.
May be we need to **refactor** the code?
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee merged pull request #19001: [fix](function) Support more behaviors of cast time in MySQL
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #19001:
URL: https://github.com/apache/doris/pull/19001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19001: [fix](function) Support more behaviors of cast time in MySQL.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #19001:
URL: https://github.com/apache/doris/pull/19001#issuecomment-1519650575
run builall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19001: [fix](function) Support more behaviors of cast time in MySQL
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #19001:
URL: https://github.com/apache/doris/pull/19001#issuecomment-1520230559
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.96 seconds
stream load tsv: 424 seconds loaded 74807831229 Bytes, about 168 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230424140810_clickbench_pr_134140.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19001: [fix](function) Support more behaviors of cast time in MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #19001:
URL: https://github.com/apache/doris/pull/19001#issuecomment-1520912698
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19001: [fix](function) Support more behaviors of cast time in MySQL.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19001:
URL: https://github.com/apache/doris/pull/19001#issuecomment-1519654022
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19001: [fix](function) Support more behaviors of cast time in MySQL.
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #19001:
URL: https://github.com/apache/doris/pull/19001#issuecomment-1519661891
run builall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19001: [fix](function) Support more behaviors of cast time in MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #19001:
URL: https://github.com/apache/doris/pull/19001#issuecomment-1520191491
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org