[jira] [Commented] (LUCENE-6154) nuke FilterDirectory.unwrap or make package-private

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262280#comment-14262280 ] 

Robert Muir commented on LUCENE-6154:
-------------------------------------

One solution is to move IOUtils.spins() -> Directory.spins().
The current logic would move into the respective implementations (e.g. ramdirectory returns false always). The hairy one would go in FSDirectory.

But maybe it is not important enough to belong here and should remain a hack, instead the static method moved to the .store package.

> nuke FilterDirectory.unwrap or make package-private
> ---------------------------------------------------
>
>                 Key: LUCENE-6154
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6154
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>
> As Uwe points out, this is dangerous. The only thing using it is its test: TestFilterDirectory.testUnwrap() and IOUtils.spins().
> If this method is implemented in some other way, we could remove it. otherwise maybe it can be package-private.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org