You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/12/25 10:41:37 UTC
[GitHub] [maven-surefire] slawekjaranowski opened a new pull request #415: [SUREFIRE-1955] Switch project to Java 8
slawekjaranowski opened a new pull request #415:
URL: https://github.com/apache/maven-surefire/pull/415
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #415: [SUREFIRE-1955] Switch project to Java 8
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #415:
URL: https://github.com/apache/maven-surefire/pull/415#issuecomment-1001437135
This PR only change Java version to 1.8 with only necessary changes to make project build.
So it is for 1 only from your list.
Maven Api was changed in #412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #415: [SUREFIRE-1955] Switch project to Java 8
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #415:
URL: https://github.com/apache/maven-surefire/pull/415#issuecomment-1001159989
Usually, we split this activity to multiple activities.
1. changing the Maven parent POM and Java Version 1.8 in POM.
2. Changing the Maven API version
3. changing the code towards Java 8 (there is one plugin which converts the code to java 8 features)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #415: [SUREFIRE-1955] Switch project to Java 8
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #415:
URL: https://github.com/apache/maven-surefire/pull/415#issuecomment-1002813962
@slawekjaranowski
The build process is currently using two JDKs. One is 1.8 and the other is in the range [1.7, ).
This movement towards 1.8 would simplify and finally only one JDK will be used.
So please go to the Jenkinsfile and remove `jdkTestName` and rename it with `jdkName`, and `final String jdkName = jenkinsEnv.jdkFromVersion(os, '8')`
and substitute
`final String jdkTestName = jenkinsEnv.jdkFromVersion(os, jdk.toString())`
with
`final String jdkName = jenkinsEnv.jdkFromVersion(os, jdk.toString())`.
Then remove `def script = cmd + ['\"-DjdkHome=$JAVA_HOME_IT\"']` and `def script = cmd + ['\"-DjdkHome=%JAVA_HOME_IT%\"']` and rename `script.join(' ')` with `cmd.join(' ')`.
Then remove the following in `maven-failsafe-plugin/pom.xml`
``` <configuration>
<javaHome>${jdkHome}</javaHome>
</configuration>
```
Pls remove `-DjdkHome=...` from README.md.
Remove `<jvm>${jdkHome}/bin/java</jvm>` and `<property>jdkHome</property>` from the main POM.
Remove `<jvm>${jdkHome}/bin/java</jvm>` from the `surefire-its/pom.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #415: [SUREFIRE-1955] Switch project to Java 8
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #415:
URL: https://github.com/apache/maven-surefire/pull/415#issuecomment-1003173208
`animal-sniffer-maven-plugin` in next PR, there is one #411 - can be reopened after it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #415: [SUREFIRE-1955] Switch project to Java 8
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #415:
URL: https://github.com/apache/maven-surefire/pull/415#issuecomment-1002992437
@slawekjaranowski
The plugin `animal-sniffer-maven-plugin` has a newer version `1.20`. It is used to check the JDK API signatures. We can update the version here or in another PR. It's up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #415: [SUREFIRE-1955] Switch project to Java 8
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #415:
URL: https://github.com/apache/maven-surefire/pull/415#issuecomment-1002813962
@slawekjaranowski
The build process is currently using two JDKs. One is 1.8 and the other is in the range [1.7, ) for tests.
This movement towards 1.8 would simplify and finally only one JDK will be used.
So please go to the Jenkinsfile and remove `jdkTestName` and rename it with `jdkName`, and `final String jdkName = jenkinsEnv.jdkFromVersion(os, '8')`
and substitute
`final String jdkTestName = jenkinsEnv.jdkFromVersion(os, jdk.toString())`
with
`final String jdkName = jenkinsEnv.jdkFromVersion(os, jdk.toString())`.
Then remove `def script = cmd + ['\"-DjdkHome=$JAVA_HOME_IT\"']` and `def script = cmd + ['\"-DjdkHome=%JAVA_HOME_IT%\"']` and rename `script.join(' ')` with `cmd.join(' ')`.
Then remove the following in `maven-failsafe-plugin/pom.xml`:
```
<configuration>
<javaHome>${jdkHome}</javaHome>
</configuration>
```
Pls remove `-DjdkHome=...` from README.md.
Remove `<jvm>${jdkHome}/bin/java</jvm>` and `<property>jdkHome</property>` from the main POM.
Remove `<jvm>${jdkHome}/bin/java</jvm>` from the `surefire-its/pom.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski merged pull request #415: [SUREFIRE-1955] Switch project to Java 8
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged pull request #415:
URL: https://github.com/apache/maven-surefire/pull/415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #415: [SUREFIRE-1955] Switch project to Java 8
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #415:
URL: https://github.com/apache/maven-surefire/pull/415#issuecomment-1002813962
@slawekjaranowski
The build process is currently using two JDKs. One is 1.8 and the other is in the range [1.7, ).
This movement towards 1.8 would simplify and finally only one JDK will be used.
So please go to the Jenkinsfile and remove `jdkTestName` and rename it with `jdkName`, and `final String jdkName = jenkinsEnv.jdkFromVersion(os, '8')`
and substitute
`final String jdkTestName = jenkinsEnv.jdkFromVersion(os, jdk.toString())`
with
`final String jdkName = jenkinsEnv.jdkFromVersion(os, jdk.toString())`.
Then remove `def script = cmd + ['\"-DjdkHome=$JAVA_HOME_IT\"']` and `def script = cmd + ['\"-DjdkHome=%JAVA_HOME_IT%\"']` and rename `script.join(' ')` with `cmd.join(' ')`.
Then remove the following in `maven-failsafe-plugin/pom.xml`:
```
<configuration>
<javaHome>${jdkHome}</javaHome>
</configuration>
```
Pls remove `-DjdkHome=...` from README.md.
Remove `<jvm>${jdkHome}/bin/java</jvm>` and `<property>jdkHome</property>` from the main POM.
Remove `<jvm>${jdkHome}/bin/java</jvm>` from the `surefire-its/pom.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org