You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Steve Huston (JIRA)" <qp...@incubator.apache.org> on 2009/07/22 01:31:14 UTC

[jira] Commented: (QPID-1918) Patches/files for Windows QMF plug-in support

    [ https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733902#action_12733902 ] 

Steve Huston commented on QPID-1918:
------------------------------------

The PipeHandle.cpp changes (simplified to always use TCP, never _pipe) were integrated in trunk r796577.

The ManagementAgentImpl.cpp change seems like it should maybe be handled more like the agent-not-initialized code in ManagementAgentImpl::ConnectionThread, but I didn't study this too closely... could you please check this out?

The uuid situation seems to have changed wrt includes... could you please re-evaluate your situation against trunk?

I'm a little uneasy about relying on Condor's autotools check for HAVE_... in IntegerTypes.h so I'm still thinking about this one. How does Condor get a size_t and pid_t type? Is it picking it up somewhere from Visual Studio, or defining them locally?

Re VS project file updates... I'm not devoting any more time to maintaining them. As soon as I have a little free time, I'm going to remove them all, so it's best to get the cmake stuff going. CMake will generate Visual Studio projects from which you can build, debug, etc. so it's just getting over the CMake step that's a hassle at first. I have a README in progress that explains it further and will try to get it check in soon.


> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
>                 Key: QPID-1918
>                 URL: https://issues.apache.org/jira/browse/QPID-1918
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Qpid Managment Framework
>         Environment: Windows XP SP3, VC++ 9.0
>            Reporter: Pete MacKinnon
>            Assignee: Steve Huston
>         Attachments: qpid-1918.zip
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision: 785848
> Need Static builds (release and debug) for correct runtime integration with Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj  
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org