You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/03/22 09:47:43 UTC
Review Request 66211: Added the fields `ExposedPorts` and `Volumes`
into Docker v1 image spec.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66211/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Bugs: MESOS-8718
https://issues.apache.org/jira/browse/MESOS-8718
Repository: mesos
Description
-------
Added the fields `ExposedPorts` and `Volumes` into Docker v1 image spec.
Diffs
-----
include/mesos/docker/v1.proto 338675490b7e624196bbb745173daa028a13280c
Diff: https://reviews.apache.org/r/66211/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 66211: Added the fields `ExposedPorts` and
`Volumes` into Docker v1 image spec.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66211/#review200146
-----------------------------------------------------------
We were planning to land these patches when we need them. For example, the volume defined in docker images may not fit in Mesos' model.
- Gilbert Song
On March 22, 2018, 2:47 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66211/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 2:47 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8718
> https://issues.apache.org/jira/browse/MESOS-8718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the fields `ExposedPorts` and `Volumes` into Docker v1 image spec.
>
>
> Diffs
> -----
>
> include/mesos/docker/v1.proto 338675490b7e624196bbb745173daa028a13280c
>
>
> Diff: https://reviews.apache.org/r/66211/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>