You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/05/04 13:13:55 UTC
[GitHub] carbondata pull request #2270: [CARBONDATA-2438][Build] Remove hadoop/spark/...
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/2270
[CARBONDATA-2438][Build] Remove hadoop/spark/zookeeper related classes from assembly
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NA`
- [x] Any backward compatibility impacted?
`NA`
- [x] Document update required?
`NA`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
`NA`
- How it is tested? Please attach test report.
`NA`
- Is it a performance related change? Please attach the performance test report.
`NA`
- Any additional information to help reviewers in testing this change.
`NA`
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
`NA`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 0504_assembly
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2270
----
commit de2fc543a2c2af611c3a44ea68e3b882175280d8
Author: xuchuanyin <xu...@...>
Date: 2018-05-04T13:11:17Z
Remove hadoop/spark/zookeeper related classes from assembly
----
---
[GitHub] carbondata issue #2270: [CARBONDATA-2438][Assembly] Remove hadoop/spark/zook...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2270
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4491/
---
[GitHub] carbondata issue #2270: [CARBONDATA-2438][Assembly] Remove hadoop/spark/zook...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2270
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5651/
---
[GitHub] carbondata pull request #2270: [CARBONDATA-2438][Assembly] Remove hadoop/spa...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2270#discussion_r186095004
--- Diff: assembly/pom.xml ---
@@ -89,7 +89,18 @@
<artifactSet>
<includes>
<include>*:*</include>
+ <!--use the following line if we only want carbondata related classes-->
+ <!--<include>org.apache.carbondata:*</include>-->
</includes>
+ <excludes>
+ <exclude>org.apache.hadoop:*</exclude>
--- End diff --
FYI: Fllowings are known classes that are provided by spark.
---
[GitHub] carbondata pull request #2270: [CARBONDATA-2438][Assembly] Remove hadoop/spa...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2270#discussion_r186094736
--- Diff: assembly/pom.xml ---
@@ -89,7 +89,18 @@
<artifactSet>
<includes>
<include>*:*</include>
+ <!--use the following line if we only want carbondata related classes-->
+ <!--<include>org.apache.carbondata:*</include>-->
--- End diff --
FYI: If we use this line of code, the assembly jar will only contain carbondata related classes and the final size of assembly-jar will be about 7MB.
But there will be some problems: If carbon use an artifact that is not provided by spark, it will cause runtime error. So we'd better to keep the classes and only remove those are known to be provided by spark.
---
[GitHub] carbondata pull request #2270: [CARBONDATA-2438][Assembly] Remove hadoop/spa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2270
---
[GitHub] carbondata issue #2270: [CARBONDATA-2438][Assembly] Remove hadoop/spark/zook...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2270
LGTM
---
[GitHub] carbondata issue #2270: [CARBONDATA-2438][Assembly] Remove hadoop/spark/zook...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2270
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4728/
---