You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/28 18:21:38 UTC

[GitHub] [beam] TheNeuralBit edited a comment on pull request #15826: Minor: Replace usage of SqlExpressionChecker with ExpressionChecker

TheNeuralBit edited a comment on pull request #15826:
URL: https://github.com/apache/beam/pull/15826#issuecomment-954087467


   Should we be using `SqlExpressionChecker` for more checks then? Why just string functions? 
   
   It seems like this is a contrived way to get some test coverage of the JDBC path, perhaps we should just add some explicit tests for that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org