You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Stepan Koltsov (JIRA)" <ji...@apache.org> on 2006/10/31 02:46:16 UTC

[jira] Created: (LANG-292) unescapeXml("&12345678;") should be "&12345678;"

unescapeXml("&12345678;") should be "&12345678;"
------------------------------------------------

                 Key: LANG-292
                 URL: http://issues.apache.org/jira/browse/LANG-292
             Project: Commons Lang
          Issue Type: Bug
    Affects Versions: Nightly Builds
            Reporter: Stepan Koltsov
            Priority: Minor


Following test (in EntitiesTest.java) fails:

    public void testNumberOverflow() throws Exception {
        doTestUnescapeEntity("&#12345678;", "&#12345678;");
        doTestUnescapeEntity("x&#12345678;y", "x&#12345678;y");
        doTestUnescapeEntity("&#x12345678;", "&#x12345678;");
        doTestUnescapeEntity("x&#x12345678;y", "x&#x12345678;y");
    }

Maximim value for char is 0xFFFF, so &#12345678; is invalid entity reference, and so should be left as is.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org

[jira] Updated: (LANG-292) unescapeXml("&12345678;") should be "&12345678;"

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LANG-292?page=all ]

Henri Yandell updated LANG-292:
-------------------------------

    Fix Version/s: 3.0

Test confirmed:

Testcase: testNumberOverflow(org.apache.commons.lang.EntitiesTest): FAILED
expected:<&#12345678;> but was:<?>
junit.framework.ComparisonFailure: expected:<&#12345678;> but was:<?>
    at org.apache.commons.lang.EntitiesTest.doTestUnescapeEntity(EntitiesTest.java:101)
    at org.apache.commons.lang.EntitiesTest.testNumberOverflow(EntitiesTest.java:201)

> unescapeXml("&12345678;") should be "&12345678;"
> ------------------------------------------------
>
>                 Key: LANG-292
>                 URL: http://issues.apache.org/jira/browse/LANG-292
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: Stepan Koltsov
>            Priority: Minor
>             Fix For: 3.0
>
>
> Following test (in EntitiesTest.java) fails:
>     public void testNumberOverflow() throws Exception {
>         doTestUnescapeEntity("&#12345678;", "&#12345678;");
>         doTestUnescapeEntity("x&#12345678;y", "x&#12345678;y");
>         doTestUnescapeEntity("&#x12345678;", "&#x12345678;");
>         doTestUnescapeEntity("x&#x12345678;y", "x&#x12345678;y");
>     }
> Maximim value for char is 0xFFFF, so &#12345678; is invalid entity reference, and so should be left as is.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org

[jira] Resolved: (LANG-292) unescapeXml("&12345678;") should be "&12345678;"

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LANG-292?page=all ]

Henri Yandell resolved LANG-292.
--------------------------------

    Fix Version/s: 2.3
                       (was: 3.0)
       Resolution: Fixed

 svn ci -m "Applying unit test and fix for #LANG-292. Also fixes a couple of problems with the unescape(Writer..) overload that came up" src/test/org/apache/commons/lang/EntitiesTest.java src/java/org/apache/commons/lang/Entities.java 

Sending        src/java/org/apache/commons/lang/Entities.java
Sending        src/test/org/apache/commons/lang/EntitiesTest.java
Transmitting file data ..
Committed revision 469661.


> unescapeXml("&12345678;") should be "&12345678;"
> ------------------------------------------------
>
>                 Key: LANG-292
>                 URL: http://issues.apache.org/jira/browse/LANG-292
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: Stepan Koltsov
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: LANG-292.patch
>
>
> Following test (in EntitiesTest.java) fails:
>     public void testNumberOverflow() throws Exception {
>         doTestUnescapeEntity("&#12345678;", "&#12345678;");
>         doTestUnescapeEntity("x&#12345678;y", "x&#12345678;y");
>         doTestUnescapeEntity("&#x12345678;", "&#x12345678;");
>         doTestUnescapeEntity("x&#x12345678;y", "x&#x12345678;y");
>     }
> Maximim value for char is 0xFFFF, so &#12345678; is invalid entity reference, and so should be left as is.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org

[jira] Updated: (LANG-292) unescapeXml("&12345678;") should be "&12345678;"

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LANG-292?page=all ]

Henri Yandell updated LANG-292:
-------------------------------

    Attachment: LANG-292.patch

Unit test patch with fix. 

Also includes a break; statement in the unescape(Writer) method that was missing (GAH!). It's terrible how these methods have ended up not being coded in the same way.

> unescapeXml("&12345678;") should be "&12345678;"
> ------------------------------------------------
>
>                 Key: LANG-292
>                 URL: http://issues.apache.org/jira/browse/LANG-292
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: Stepan Koltsov
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: LANG-292.patch
>
>
> Following test (in EntitiesTest.java) fails:
>     public void testNumberOverflow() throws Exception {
>         doTestUnescapeEntity("&#12345678;", "&#12345678;");
>         doTestUnescapeEntity("x&#12345678;y", "x&#12345678;y");
>         doTestUnescapeEntity("&#x12345678;", "&#x12345678;");
>         doTestUnescapeEntity("x&#x12345678;y", "x&#x12345678;y");
>     }
> Maximim value for char is 0xFFFF, so &#12345678; is invalid entity reference, and so should be left as is.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org