Re: [PR] feat(chart): download CSV chart contents from S3 for Athena charts [superset]

["Vitor-Avila (via GitHub)" <gi...@apache.org>]

Vitor-Avila commented on PR #31485:
URL: https://github.com/apache/superset/pull/31485#issuecomment-3361277251

   Does it make sense to actually expose these configs (`SUPERSET_REGION`, `SUPERSET_WORKGROUP` and `SUPERSET_ATHENA_DB`, etc) in the DB connection form? @betodealmeida I don't think we can currently use any of the existing fields in Other/etc to add a JSON with these settings, right? It might require creating a dynamic form for Athena... Just thinking that if the Superset installation has multiple Athena connections, you might need different values for each based on the DB connection, and having it at the connection dialog would be simpler for users to manage it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org