You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "adarshsanjeev (via GitHub)" <gi...@apache.org> on 2023/02/24 06:24:50 UTC
[GitHub] [druid] adarshsanjeev opened a new pull request, #13844: Change test name so it triggers in CI
adarshsanjeev opened a new pull request, #13844:
URL: https://github.com/apache/druid/pull/13844
As the name of the class did not end or start with "Test", `CalciteSelectQueryMSQTest` was not triggered in CI. This PR renames the test.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on pull request #13844: Change test name so it triggers in CI
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on PR #13844:
URL: https://github.com/apache/druid/pull/13844#issuecomment-1447206229
Yes, now that the test actually runs in GHA, we're seeing failures that didn't previously show up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] adarshsanjeev commented on pull request #13844: Change test name so it triggers in CI
Posted by "adarshsanjeev (via GitHub)" <gi...@apache.org>.
adarshsanjeev commented on PR #13844:
URL: https://github.com/apache/druid/pull/13844#issuecomment-1475906681
Thanks, @paul-rogers! I have resolved the failures and merge conflicts, the PR should be good to go. Regarding the test failures, the cause does not seem to have been introduced by a specific PR (at least not that I can tell), but some discrepancies that have always existed due to how MSQ handles it. I think there are more than these as all tests have not been ported to `CalciteSelectQueryMSQTest` yet.
I have raised two issues to cover these.
https://github.com/apache/druid/issues/13950
https://github.com/apache/druid/issues/13951
I can raise these in the Apache community slack to discuss how to handle these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on pull request #13844: Change test name so it triggers in CI
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on PR #13844:
URL: https://github.com/apache/druid/pull/13844#issuecomment-1459100095
@adarshsanjeev, checking back on this one. There is a merge conflict to resolve and test failures which might need assistance from the folks who wrote the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe commented on pull request #13844: Change test name so it triggers in CI
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe commented on PR #13844:
URL: https://github.com/apache/druid/pull/13844#issuecomment-1446105390
@adarshsanjeev Looks like there are some legit test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] adarshsanjeev commented on a diff in pull request #13844: Change test name so it triggers in CI
Posted by "adarshsanjeev (via GitHub)" <gi...@apache.org>.
adarshsanjeev commented on code in PR #13844:
URL: https://github.com/apache/druid/pull/13844#discussion_r1118301735
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/CalciteSelectQueryMSQTest.java:
##########
@@ -161,4 +165,19 @@ public void testQueryWithMoreThanMaxNumericInFilter()
}
+ @Test
+ @Override
+ public void testArrayAggQueryOnComplexDatatypes()
Review Comment:
Done. Added comments for both tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on a diff in pull request #13844: Change test name so it triggers in CI
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on code in PR #13844:
URL: https://github.com/apache/druid/pull/13844#discussion_r1117805526
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/CalciteSelectQueryMSQTest.java:
##########
@@ -161,4 +165,19 @@ public void testQueryWithMoreThanMaxNumericInFilter()
}
+ @Test
+ @Override
+ public void testArrayAggQueryOnComplexDatatypes()
Review Comment:
Would be worth including an explanation that this feature does not work on MSQ, but does work with "classic" queries. Might be wroth also adding links between the tests to cross-reference the MSQ vs. "classic" case.
That way, if this ever changes in the future, folks can sort out where the two copies of the test live.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe merged pull request #13844: Change test name so it triggers in CI
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #13844:
URL: https://github.com/apache/druid/pull/13844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org