You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/11 12:47:18 UTC

[GitHub] [pulsar] eolivelli commented on a diff in pull request #15541: [improve][test] Reduce LedgerUnderreplicationManagerTest flakyness

eolivelli commented on code in PR #15541:
URL: https://github.com/apache/pulsar/pull/15541#discussion_r870258302


##########
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/bookkeeper/LedgerUnderreplicationManagerTest.java:
##########
@@ -84,8 +86,10 @@ private Future<Long> getLedgerToReplicate(LedgerUnderreplicationManager m) {
 
     private String basePath;
     private String urLedgerPath;
+    private Executor executor;
 
     private void methodSetup(Supplier<String> urlSupplier) throws Exception {
+        this.executor = Executors.newSingleThreadExecutor();

Review Comment:
   it looks like we are not shutting down this executor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org