You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/05/14 10:02:41 UTC
Review Request 21429: CLOUDSTACK-6663: Agent fails to start on some setups
if last nic on host in nic list doesn't contain unicast address
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21429/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Rajesh Battala.
Bugs: CLOUDSTACK-6663
https://issues.apache.org/jira/browse/CLOUDSTACK-6663
Repository: cloudstack-git
Description
-------
Before starting Hyper-V agent we initialize HypervResourceController. We try to initialize it with IP address 0.0.0.0. We try to get nic info of 0.0.0.0. To get nic info we iterate through all nics and return the last NIC in the list if it doesn't match with any IP address. So in case last NIC doesn't have unicastAddress, Hyper-V agent will fail to start.
We don't need IP address during initialization. It get initialized with startupcommand later
Diffs
-----
plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentService.cs 9d66a5c
Diff: https://reviews.apache.org/r/21429/diff/
Testing
-------
Hyper-V Agent starts up without any problem.
Created the basic Hyper-V setup and it works fine
Thanks,
Anshul Gangwar
Re: Review Request 21429: CLOUDSTACK-6663: Agent fails to start on some
setups if last nic on host in nic list doesn't contain unicast address
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21429/#review43950
-----------------------------------------------------------
Commit 26fa623ffd427fa996968ce4e16c0262f7dd016e in cloudstack's branch refs/heads/master from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=26fa623 ]
CLOUDSTACK-6663: Fixed Hyper-V agent fails to start on some setups. During startup agent tries
to get nic info of 0.0.0.0. To get it, it iterates through all nics and return the last NIC in
the list if it doesn't match with any IP address. In case last NIC doesn't have unicastAddress,
Hyper-V agent will fail to start. We don't need IP address during initialization. It get
initialized with startupcommand later.
- ASF Subversion and Git Services
On May 14, 2014, 8:02 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21429/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 8:02 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6663
> https://issues.apache.org/jira/browse/CLOUDSTACK-6663
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Before starting Hyper-V agent we initialize HypervResourceController. We try to initialize it with IP address 0.0.0.0. We try to get nic info of 0.0.0.0. To get nic info we iterate through all nics and return the last NIC in the list if it doesn't match with any IP address. So in case last NIC doesn't have unicastAddress, Hyper-V agent will fail to start.
>
> We don't need IP address during initialization. It get initialized with startupcommand later
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentService.cs 9d66a5c
>
> Diff: https://reviews.apache.org/r/21429/diff/
>
>
> Testing
> -------
>
> Hyper-V Agent starts up without any problem.
> Created the basic Hyper-V setup and it works fine
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 21429: CLOUDSTACK-6663: Agent fails to start on some
setups if last nic on host in nic list doesn't contain unicast address
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21429/#review43951
-----------------------------------------------------------
Ship it!
Ship It!
- Devdeep Singh
On May 14, 2014, 8:02 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21429/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 8:02 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6663
> https://issues.apache.org/jira/browse/CLOUDSTACK-6663
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Before starting Hyper-V agent we initialize HypervResourceController. We try to initialize it with IP address 0.0.0.0. We try to get nic info of 0.0.0.0. To get nic info we iterate through all nics and return the last NIC in the list if it doesn't match with any IP address. So in case last NIC doesn't have unicastAddress, Hyper-V agent will fail to start.
>
> We don't need IP address during initialization. It get initialized with startupcommand later
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentService.cs 9d66a5c
>
> Diff: https://reviews.apache.org/r/21429/diff/
>
>
> Testing
> -------
>
> Hyper-V Agent starts up without any problem.
> Created the basic Hyper-V setup and it works fine
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 21429: CLOUDSTACK-6663: Agent fails to start on some
setups if last nic on host in nic list doesn't contain unicast address
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21429/#review43949
-----------------------------------------------------------
Commit b85f687cd7f12cd14a1feeb80593ba55e05b2fa8 in cloudstack's branch refs/heads/4.4-forward from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b85f687 ]
CLOUDSTACK-6663: Fixed Hyper-V agent fails to start on some setups. During startup agent tries
to get nic info of 0.0.0.0. To get it, it iterates through all nics and return the last NIC in
the list if it doesn't match with any IP address. In case last NIC doesn't have unicastAddress,
Hyper-V agent will fail to start. We don't need IP address during initialization. It get
initialized with startupcommand later.
- ASF Subversion and Git Services
On May 14, 2014, 8:02 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21429/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 8:02 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6663
> https://issues.apache.org/jira/browse/CLOUDSTACK-6663
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Before starting Hyper-V agent we initialize HypervResourceController. We try to initialize it with IP address 0.0.0.0. We try to get nic info of 0.0.0.0. To get nic info we iterate through all nics and return the last NIC in the list if it doesn't match with any IP address. So in case last NIC doesn't have unicastAddress, Hyper-V agent will fail to start.
>
> We don't need IP address during initialization. It get initialized with startupcommand later
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentService.cs 9d66a5c
>
> Diff: https://reviews.apache.org/r/21429/diff/
>
>
> Testing
> -------
>
> Hyper-V Agent starts up without any problem.
> Created the basic Hyper-V setup and it works fine
>
>
> Thanks,
>
> Anshul Gangwar
>
>
Re: Review Request 21429: CLOUDSTACK-6663: Agent fails to start on
some setups if last nic on host in nic list doesn't contain unicast address
Posted by Ishfaq Malik <is...@pack-net.co.uk>.
Hi there
I shouldn't be in this mailing list. I have no interaction with cloudstack.
Could someone please remove me as I can't see how to.
Regards
Ish
On 27 May 2014 09:44, ASF Subversion and Git Services <
asfbot@urd.zones.apache.org> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21429/#review43957
> -----------------------------------------------------------
>
>
> Commit 92bc68d1f14a22f1a5b6bbf87ed349f5b440b149 in cloudstack's branch
> refs/heads/4.4 from Anshul Gangwar
> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=92bc68d ]
>
> CLOUDSTACK-6663: Fixed Hyper-V agent fails to start on some setups. During
> startup agent tries
> to get nic info of 0.0.0.0. To get it, it iterates through all nics and
> return the last NIC in
> the list if it doesn't match with any IP address. In case last NIC doesn't
> have unicastAddress,
> Hyper-V agent will fail to start. We don't need IP address during
> initialization. It get
> initialized with startupcommand later.
>
>
> - ASF Subversion and Git Services
>
>
> On May 14, 2014, 8:02 a.m., Anshul Gangwar wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/21429/
> > -----------------------------------------------------------
> >
> > (Updated May 14, 2014, 8:02 a.m.)
> >
> >
> > Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> >
> >
> > Bugs: CLOUDSTACK-6663
> > https://issues.apache.org/jira/browse/CLOUDSTACK-6663
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > -------
> >
> > Before starting Hyper-V agent we initialize HypervResourceController. We
> try to initialize it with IP address 0.0.0.0. We try to get nic info of
> 0.0.0.0. To get nic info we iterate through all nics and return the last
> NIC in the list if it doesn't match with any IP address. So in case last
> NIC doesn't have unicastAddress, Hyper-V agent will fail to start.
> >
> > We don't need IP address during initialization. It get initialized with
> startupcommand later
> >
> >
> > Diffs
> > -----
> >
> >
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentService.cs
> 9d66a5c
> >
> > Diff: https://reviews.apache.org/r/21429/diff/
> >
> >
> > Testing
> > -------
> >
> > Hyper-V Agent starts up without any problem.
> > Created the basic Hyper-V setup and it works fine
> >
> >
> > Thanks,
> >
> > Anshul Gangwar
> >
> >
>
>
--
Ishfaq Malik
Department: VOIP Support
Company: Packnet Limited
t: +44 (0)845 004 4994
f: +44 (0)161 660 9825
e: ish@pack-net.co.uk
w: http://www.pack-net.co.uk
Registered Address: PACKNET LIMITED, Duplex 2, Ducie House
37 Ducie Street
Manchester, M1 2JW
COMPANY REG NO. 04920552
Re: Review Request 21429: CLOUDSTACK-6663: Agent fails to start on some
setups if last nic on host in nic list doesn't contain unicast address
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21429/#review43957
-----------------------------------------------------------
Commit 92bc68d1f14a22f1a5b6bbf87ed349f5b440b149 in cloudstack's branch refs/heads/4.4 from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=92bc68d ]
CLOUDSTACK-6663: Fixed Hyper-V agent fails to start on some setups. During startup agent tries
to get nic info of 0.0.0.0. To get it, it iterates through all nics and return the last NIC in
the list if it doesn't match with any IP address. In case last NIC doesn't have unicastAddress,
Hyper-V agent will fail to start. We don't need IP address during initialization. It get
initialized with startupcommand later.
- ASF Subversion and Git Services
On May 14, 2014, 8:02 a.m., Anshul Gangwar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21429/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 8:02 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6663
> https://issues.apache.org/jira/browse/CLOUDSTACK-6663
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Before starting Hyper-V agent we initialize HypervResourceController. We try to initialize it with IP address 0.0.0.0. We try to get nic info of 0.0.0.0. To get nic info we iterate through all nics and return the last NIC in the list if it doesn't match with any IP address. So in case last NIC doesn't have unicastAddress, Hyper-V agent will fail to start.
>
> We don't need IP address during initialization. It get initialized with startupcommand later
>
>
> Diffs
> -----
>
> plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentService.cs 9d66a5c
>
> Diff: https://reviews.apache.org/r/21429/diff/
>
>
> Testing
> -------
>
> Hyper-V Agent starts up without any problem.
> Created the basic Hyper-V setup and it works fine
>
>
> Thanks,
>
> Anshul Gangwar
>
>