[GitHub] [ozone] ivanzlenko commented on a diff in pull request #5233: HDDS-9203. Allow generating/revoking S3 secret for other users via REST

["ivanzlenko (via GitHub)" <gi...@apache.org>]

ivanzlenko commented on code in PR #5233:
URL: https://github.com/apache/ozone/pull/5233#discussion_r1311242158


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3secret/S3SecretGenerateEndpoint.java:
##########
@@ -34,16 +36,30 @@
 public class S3SecretGenerateEndpoint extends S3SecretEndpointBase {
   @POST
   public Response generate() throws IOException {
+    return generateInternal(null);
+  }
+
+  @POST
+  @Path("/{username}")
+  public Response generate(@PathParam("username") String username)

Review Comment:
   @ChenSammi thanks! I've changed this API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org