[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7007: Fixes to RP2040 SMART flash and documentation

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #7007:
URL: https://github.com/apache/incubator-nuttx/pull/7007#discussion_r963064836


##########
fs/smartfs/smartfs_smart.c:
##########
@@ -643,12 +639,12 @@ static ssize_t smartfs_read(FAR struct file *filep, char *buffer,
   finfo("Read %lu bytes:", bytesread);
   for (uint32_t i = 0; i < bytesread; ++i)
     {
-      if ((i & 0x0f) == 0) printf("\n    ");
+      if ((i & 0x0f) == 0) finfo("\n    ");
 
-      printf("%02x, ", buffer[i]);
+      finfo("%02x, ", buffer[i]);

Review Comment:
   ditto



##########
fs/smartfs/smartfs_smart.c:
##########
@@ -679,12 +675,12 @@ static ssize_t smartfs_write(FAR struct file *filep, const char *buffer,
   finfo("Writing %lu bytes:", (uint32_t)buflen);

Review Comment:
   ```suggestion
     finfo("Writing %zu bytes:", buflen);
   ```



##########
fs/smartfs/smartfs_smart.c:
##########
@@ -679,12 +675,12 @@ static ssize_t smartfs_write(FAR struct file *filep, const char *buffer,
   finfo("Writing %lu bytes:", (uint32_t)buflen);
   for (uint32_t i = 0; i < buflen; ++i)
     {
-      if ((i & 0x0f) == 0) printf("\n    ");
+      if ((i & 0x0f) == 0) finfo("\n    ");
 
-      printf("%02x, ", buffer[i]);
+      finfo("%02x, ", buffer[i]);

Review Comment:
   it doesn't work since syslog may prefix some tag and append '\n' always.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org