You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/10 07:15:26 UTC
[GitHub] [pulsar-client-go] hrsakai opened a new pull request #413: Fix discard unacked messages
hrsakai opened a new pull request #413:
URL: https://github.com/apache/pulsar-client-go/pull/413
https://github.com/apache/pulsar-client-go/issues/389#issuecomment-741560624
### Motivation
When a consumer whose receive queue is not empty reconnects to a broker, unacked messages don't be redelivered to a client application and these are removed from backlog.
This is because StartMessageID is updated and the consumer implicitly acks redelivered unacked messages.
https://github.com/apache/pulsar-client-go/blob/v0.3.0/pulsar/consumer_partition.go#L972-L976
https://github.com/apache/pulsar-client-go/blob/v0.3.0/pulsar/consumer_partition.go#L507-L510
### Modifications
* If startMessageID is undefined, it will not be updated in order to prevent unacked messages from being discarded by following logic.
.https://github.com/apache/pulsar-client-go/blob/v0.3.0/pulsar/consumer_partition.go#L507-L510
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy merged pull request #413: Fix discard unacked messages
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #413:
URL: https://github.com/apache/pulsar-client-go/pull/413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org