You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/09 08:14:17 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2503: Re-organise ESP32 boards and introduce two more.
Ouss4 opened a new pull request #2503:
URL: https://github.com/apache/incubator-nuttx/pull/2503
## Summary
This PR re-organises the ESP32 boards and introduces the ESP-WROVER-KIT and the ESP32-Ethernet-Kit.
## Impact
Other than the new organisation, this will also have a few new configs during the daily CI checks.
## Testing
All the configs build and work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2503: Re-organise ESP32 boards and introduce two more.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2503:
URL: https://github.com/apache/incubator-nuttx/pull/2503#issuecomment-741612114
@btashton @xiaoxiang781216 please be aware that few more jobs will be added to the CI with this since Xtensa is included as a whole directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2503: Re-organise ESP32 boards and introduce two more.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2503:
URL: https://github.com/apache/incubator-nuttx/pull/2503#discussion_r540244446
##########
File path: boards/xtensa/esp32/common/src/esp32_wdt.c
##########
@@ -23,33 +23,34 @@
****************************************************************************/
#include <nuttx/config.h>
+
+#include <sys/types.h>
#include <debug.h>
+
#include "esp32_wtd_lowerhalf.h"
Review comment:
Yes, the renaming will come in a different PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2503: Re-organise ESP32 boards and introduce two more.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2503:
URL: https://github.com/apache/incubator-nuttx/pull/2503#issuecomment-742584165
@xiaoxiang781216 I fixed the naming in the boards/ directory, for the rest in arch/ that will come in a different PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2503: Re-organise ESP32 boards and introduce two more.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2503:
URL: https://github.com/apache/incubator-nuttx/pull/2503
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2503: Re-organise ESP32 boards and introduce two more.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2503:
URL: https://github.com/apache/incubator-nuttx/pull/2503#discussion_r546229104
##########
File path: boards/xtensa/esp32/esp32-devkitc/README.txt
##########
@@ -39,6 +39,9 @@ STATUS
Espressif is working to include support to WiFi and Bluetooth, but
it will depends on their external libraries to get it up and running.
+ Wifi is supported and there is a config to demonstrate its use. Please, see
+ configs/wapi.
Review comment:
@yamt There is a config for that: ESP32_WIFI_FS_MOUNPT, it has the default value of /mnt/esp/wifi. The board bringup mounts that.
Also note that you can disable saving WIFI parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2503: Re-organise ESP32 boards and introduce two more.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2503:
URL: https://github.com/apache/incubator-nuttx/pull/2503#discussion_r540250417
##########
File path: boards/xtensa/esp32/common/src/esp32_wdt.c
##########
@@ -1,5 +1,5 @@
/****************************************************************************
- * boards/xtensa/esp32/esp32-core/src/esp32_wtd.c
+ * boards/xtensa/esp32/common/src/esp32_wtd.c
Review comment:
Thanks, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2503: Re-organise ESP32 boards and introduce two more.
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #2503:
URL: https://github.com/apache/incubator-nuttx/pull/2503#discussion_r544884005
##########
File path: boards/xtensa/esp32/esp32-devkitc/README.txt
##########
@@ -39,6 +39,9 @@ STATUS
Espressif is working to include support to WiFi and Bluetooth, but
it will depends on their external libraries to get it up and running.
+ Wifi is supported and there is a config to demonstrate its use. Please, see
+ configs/wapi.
Review comment:
how can i prepare `/mnt/esp/wifi`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2503: Re-organise ESP32 boards and introduce two more.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #2503:
URL: https://github.com/apache/incubator-nuttx/pull/2503#discussion_r540250294
##########
File path: boards/xtensa/esp32/common/include/esp32_board_tim.h
##########
@@ -18,8 +18,8 @@
*
****************************************************************************/
-#ifndef __BOARDS_XTENSA_ESP32_COMMON_INCLUDE_TIMER_H
-#define __BOARDS_XTENSA_ESP32_COMMON_INCLUDE_TIMER_H
+#ifndef __BOARDS_XTENSA_ESP32_COMMON_INCLUDE_BOARD_TIMER_H
Review comment:
Thanks. Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2503: Re-organise ESP32 boards and introduce two more.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2503:
URL: https://github.com/apache/incubator-nuttx/pull/2503#discussion_r540178668
##########
File path: boards/xtensa/esp32/common/src/esp32_wdt.c
##########
@@ -1,5 +1,5 @@
/****************************************************************************
- * boards/xtensa/esp32/esp32-core/src/esp32_wtd.c
+ * boards/xtensa/esp32/common/src/esp32_wtd.c
Review comment:
eps32_wtd.c to esp32_wdt.c
##########
File path: arch/xtensa/src/esp32/Make.defs
##########
@@ -162,10 +162,10 @@ ifeq ($(CONFIG_ESP32_PARTITION),y)
CHIP_CSRCS += esp32_partition.c
endif
-ifeq ($(CONFIG_WATCHDOG),y)
-CHIP_CSRCS += esp32_wtd_lowerhalf.c
ifeq ($(CONFIG_ESP32_WDT),y)
CHIP_CSRCS += esp32_wtd.c
+ifeq ($(CONFIG_WATCHDOG),y)
+CHIP_CSRCS += esp32_wtd_lowerhalf.c
Review comment:
esp32_wtd_lowerhalf.c to esp32_wdt_lowerhalf.c
##########
File path: boards/xtensa/esp32/common/include/esp32_board_tim.h
##########
@@ -18,8 +18,8 @@
*
****************************************************************************/
-#ifndef __BOARDS_XTENSA_ESP32_COMMON_INCLUDE_TIMER_H
-#define __BOARDS_XTENSA_ESP32_COMMON_INCLUDE_TIMER_H
+#ifndef __BOARDS_XTENSA_ESP32_COMMON_INCLUDE_BOARD_TIMER_H
Review comment:
__BOARDS_XTENSA_ESP32_COMMON_INCLUDE_BOARD_TIMER_H to
__BOARDS_XTENSA_ESP32_COMMON_INCLUDE_BOARD_TIM_H
##########
File path: arch/xtensa/src/esp32/Make.defs
##########
@@ -164,7 +164,7 @@ endif
ifeq ($(CONFIG_WATCHDOG),y)
CHIP_CSRCS += esp32_wtd_lowerhalf.c
-ifeq ($(CONFIG_ESP32_WTD),y)
+ifeq ($(CONFIG_ESP32_WDT),y)
CHIP_CSRCS += esp32_wtd.c
Review comment:
esp32_wtd.c to esp32_wdt.c
##########
File path: boards/xtensa/esp32/common/src/esp32_wdt.c
##########
@@ -23,33 +23,34 @@
****************************************************************************/
#include <nuttx/config.h>
+
+#include <sys/types.h>
#include <debug.h>
+
#include "esp32_wtd_lowerhalf.h"
Review comment:
should we change esp32_wtd_lowerhalf.h to esp32_wdt_lowerhalf.h
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org