You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Tomoe Sugihara <to...@midokura.com> on 2012/08/01 17:46:05 UTC
Review Request: Another clean up for unnecessary parameter conn Clean up
unused parameter conn. Add test for LibvirtVMDef Add support for ethernet
type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6284/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Another clean up for unnecessary parameter conn
Signed-off-by: Tomoe Sugihara <to...@midokura.com>
Clean up unused parameter conn.
Signed-off-by: Tomoe Sugihara <to...@midokura.com>
Add test for LibvirtVMDef
Signed-off-by: Tomoe Sugihara <to...@midokura.com>
Add support for ethernet type
Signed-off-by: Tomoe Sugihara <to...@midokura.com>
Diffs
-----
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ea12b986b0a771c028354637a657b100fc3cfa27
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java e1cfa548948c0ae85a8e49b99e488a192fe506f5
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/6284/diff/
Testing
-------
Thanks,
Tomoe Sugihara
Re: Review Request: Another clean up for unnecessary parameter conn Clean up
unused parameter conn. Add test for LibvirtVMDef Add support for ethernet
type
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6284/#review9713
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On Aug. 1, 2012, 3:46 p.m., Tomoe Sugihara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6284/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2012, 3:46 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Another clean up for unnecessary parameter conn
>
> Signed-off-by: Tomoe Sugihara <to...@midokura.com>
>
> Clean up unused parameter conn.
>
> Signed-off-by: Tomoe Sugihara <to...@midokura.com>
>
> Add test for LibvirtVMDef
>
> Signed-off-by: Tomoe Sugihara <to...@midokura.com>
>
> Add support for ethernet type
>
> Signed-off-by: Tomoe Sugihara <to...@midokura.com>
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ea12b986b0a771c028354637a657b100fc3cfa27
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java e1cfa548948c0ae85a8e49b99e488a192fe506f5
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6284/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomoe Sugihara
>
>