You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/09/11 16:13:55 UTC

[GitHub] [zeppelin] pan3793 commented on a diff in pull request #4652: [ZEPPELIN-5946][FOLLOWUP] Use Spark 3.4.1 and Scala 2.12 in default

pan3793 commented on code in PR #4652:
URL: https://github.com/apache/zeppelin/pull/4652#discussion_r1321781967


##########
spark/scala-2.13/src/main/scala/org/apache/zeppelin/spark/SparkScala213Interpreter.scala:
##########
@@ -129,7 +129,7 @@ class SparkScala213Interpreter(conf: SparkConf,
                           context: InterpreterContext): java.util.List[InterpreterCompletion] = {
     scalaCompletion.complete(buf.substring(0, cursor), cursor)
       .candidates
-      .map(e => new InterpreterCompletion(e.defString, e.defString, null))
+      .map(e => new InterpreterCompletion(e.name, e.name, null))

Review Comment:
   changed in https://github.com/scala/scala/pull/9510



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org