[GitHub] [spark] Yikun commented on a change in pull request #35786: [SPARK-38455][SPARK-38187][K8S][FOLLOWUP] Add driver `PodGroup` templates doc and cleanup executor `PodGroup` templates

[GitBox <gi...@apache.org>]

Yikun commented on a change in pull request #35786:
URL: https://github.com/apache/spark/pull/35786#discussion_r823392560



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala
##########
@@ -59,6 +55,7 @@ private[spark] class VolcanoFeatureStep extends KubernetesDriverCustomFeatureCon
 
     var spec = pg.getSpec
     if (spec == null) spec = new PodGroupSpec
+    // Overwrite by driver `pod.spec.priorityClassName`

Review comment:
       For type of priority class, it's the same thing, pod/pg are share the [priorityClass](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#priorityclass) in Kubernetes.
   
   Most of users are using same priorities series with pod to make sure job and pod scheduling can be considered in a whole.
   
   But I also heard some users want to set a separate priority classes for PodGroup. This is also why I raised my concern before on https://github.com/apache/spark/pull/35776#discussion_r822247430 .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org