You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jb...@apache.org on 2007/10/22 20:24:36 UTC
svn commit: r587181 -
/geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/JettyContainerImpl.java
Author: jbohn
Date: Mon Oct 22 11:24:36 2007
New Revision: 587181
URL: http://svn.apache.org/viewvc?rev=587181&view=rev
Log:
clean up GBeanInfo for Jetty6 Container GBean and add setStatsOn operation. Thanks to Viet Nguyen for pointing out the missing method
Modified:
geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/JettyContainerImpl.java
Modified: geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/JettyContainerImpl.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/JettyContainerImpl.java?rev=587181&r1=587180&r2=587181&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/JettyContainerImpl.java (original)
+++ geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/JettyContainerImpl.java Mon Oct 22 11:24:36 2007
@@ -299,17 +299,20 @@
GBeanInfoBuilder infoBuilder = GBeanInfoBuilder.createStatic("Jetty Web Container", JettyContainerImpl.class);
infoBuilder.addAttribute("statsOn", Boolean.TYPE, true);
infoBuilder.addAttribute("collectStatisticsStarted", Long.TYPE, false);
- infoBuilder.addOperation("resetStats");
-
infoBuilder.addAttribute("objectName", String.class, false);
- infoBuilder.addReference("WebManager", WebManager.class);
-
infoBuilder.addAttribute("jettyHome", String.class, true);
+
+ infoBuilder.addReference("WebManager", WebManager.class);
infoBuilder.addReference("ServerInfo", ServerInfo.class, "GBean");
+ // this is needed because the getters/setters are not added automatically
+ infoBuilder.addOperation("setStatsOn", new Class[] { boolean.class }, "void");
+ infoBuilder.addOperation("resetStats");
+
infoBuilder.addInterface(SoapHandler.class);
infoBuilder.addInterface(JettyContainer.class);
infoBuilder.addInterface(LazyStatisticsProvider.class);
+
infoBuilder.setConstructor(new String[]{"objectName", "WebManager", "jettyHome", "ServerInfo"});
GBEAN_INFO = infoBuilder.getBeanInfo();
Re: svn commit: r587181 - /geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/JettyContainerImpl.java
Posted by Anita Kulshreshtha <a_...@yahoo.com>.
Just FYI: GBeanInfoBuilder automatically adds all the operations to
GBeanInfo except getters/setters. So the resetStats() will be
automatically added but not setStatsOn(on). Hopefully we will get
around to fixing this someday..
Thanks
Anita
--- jbohn@apache.org wrote:
> Author: jbohn
> Date: Mon Oct 22 11:24:36 2007
> New Revision: 587181
>
> URL: http://svn.apache.org/viewvc?rev=587181&view=rev
> Log:
> clean up GBeanInfo for Jetty6 Container GBean and add setStatsOn
> operation. Thanks to Viet Nguyen for pointing out the missing method
>
> Modified:
>
>
geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/JettyContainerImpl.java
>
> Modified:
>
geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/JettyContainerImpl.java
> URL:
>
http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/JettyContainerImpl.java?rev=587181&r1=587180&r2=587181&view=diff
>
==============================================================================
> ---
>
geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/JettyContainerImpl.java
> (original)
> +++
>
geronimo/server/trunk/modules/geronimo-jetty6/src/main/java/org/apache/geronimo/jetty6/JettyContainerImpl.java
> Mon Oct 22 11:24:36 2007
> @@ -299,17 +299,20 @@
> GBeanInfoBuilder infoBuilder =
> GBeanInfoBuilder.createStatic("Jetty Web Container",
> JettyContainerImpl.class);
> infoBuilder.addAttribute("statsOn", Boolean.TYPE, true);
> infoBuilder.addAttribute("collectStatisticsStarted",
> Long.TYPE, false);
> - infoBuilder.addOperation("resetStats");
> -
> infoBuilder.addAttribute("objectName", String.class, false);
> - infoBuilder.addReference("WebManager", WebManager.class);
> -
> infoBuilder.addAttribute("jettyHome", String.class, true);
> +
> + infoBuilder.addReference("WebManager", WebManager.class);
> infoBuilder.addReference("ServerInfo", ServerInfo.class,
> "GBean");
>
> + // this is needed because the getters/setters are not added
> automatically
> + infoBuilder.addOperation("setStatsOn", new Class[] {
> boolean.class }, "void");
> + infoBuilder.addOperation("resetStats");
> +
> infoBuilder.addInterface(SoapHandler.class);
> infoBuilder.addInterface(JettyContainer.class);
> infoBuilder.addInterface(LazyStatisticsProvider.class);
> +
> infoBuilder.setConstructor(new String[]{"objectName",
> "WebManager", "jettyHome", "ServerInfo"});
>
> GBEAN_INFO = infoBuilder.getBeanInfo();
>
>
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com