You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by JJoe2 <gi...@git.apache.org> on 2016/10/02 17:23:04 UTC
[GitHub] log4net pull request #35: Wip/app settings
GitHub user JJoe2 opened a pull request:
https://github.com/apache/log4net/pull/35
Wip/app settings
Implementation for LOG4NET-526
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JJoe2/log4net wip/AppSettings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/log4net/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit a66d2fc61c4a1cfd8317aee41385ef6c43373ffc
Author: JoeJoe <jo...@hotmail.com>
Date: 2016-04-22T19:21:07Z
Use UTC internally to avoid ambiguous times
commit 9e9f1759d6a80594cd2d12bd54a9e3af9e7cfaa0
Author: JoeJoe <jo...@hotmail.com>
Date: 2016-04-23T19:58:36Z
Implement flushing of appenders that buffer data
commit 38fdfbaa7e9cd30e8a84fe90aa0ab12641b4db5f
Author: JoeJoe <jo...@hotmail.com>
Date: 2016-10-02T17:12:33Z
Added AppSettingPatterConverter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #35: Wip/app settings
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/log4net/pull/35
I've just realized there is no documentation outside of the API docs for the other `PatternStringConverter`s either, so yes, XML comments should be sufficient - and you've already provided that. I thought there was a section inside the manual on the web site, but don't find anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #35: Wip/app settings
Posted by JJoe2 <gi...@git.apache.org>.
Github user JJoe2 commented on the issue:
https://github.com/apache/log4net/pull/35
I'll rebase this after #36 and #37 have been processed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #35: Wip/app settings
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/log4net/pull/35
Am I correct that `AppSettingPatternConverter` and the few changes in `PatternString` are the only relevant code changes (along with adding the new filte to the solution files)? If so, I can pick up the file myself, no need to rebase the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net pull request #35: Wip/app settings
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/log4net/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #35: Wip/app settings
Posted by JJoe2 <gi...@git.apache.org>.
Github user JJoe2 commented on the issue:
https://github.com/apache/log4net/pull/35
Hi Stefan,
That's correct, those are the only changes.
Thanks,
________________________________
From: Stefan Bodewig <no...@github.com>
Sent: 23 October 2016 16:33:48
To: apache/log4net
Cc: JJoe2; Author
Subject: Re: [apache/log4net] Wip/app settings (#35)
Am I correct that AppSettingPatternConverter and the few changes in PatternString are the only relevant code changes (along with adding the new filte to the solution files)? If so, I can pick up the file myself, no need to rebase the PR.
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/apache/log4net/pull/35#issuecomment-255598419>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFY0u5TXDPotVI7EG3bo-VmOs_CBWacwks5q24xsgaJpZM4KMD7s>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #35: Wip/app settings
Posted by JJoe2 <gi...@git.apache.org>.
Github user JJoe2 commented on the issue:
https://github.com/apache/log4net/pull/35
I\u2019ll be happy to do the unit tests and possibly the doc. Are suitable XML comments enough?
Now this is added, I\u2019ll also be thinking about the next step, which is to allow the PatternString converter to be used in the XML configuration file for properties of types other than strings.
So that I can do something like:
<root>
<level type=\u201dlog4net.Util.PatternString\u201d value="%appsetting{Logging. Level}" />
</root>
Should be possible: basically be applying the PatternString conversion before converting to the target type of the property.
From: Stefan Bodewig [mailto:notifications@github.com]
Sent: 26 October 2016 20:43
To: apache/log4net
Cc: JJoe2; Author
Subject: Re: [apache/log4net] Wip/app settings (#35)
I've added your converter, many thanks.
Tests would be good and we need documentation before we can close LOG4NET-526.
\u2014
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/apache/log4net/pull/35#issuecomment-256440366>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFY0uybBZ6IZdXI75BhcToQlNLFlHQY3ks5q359EgaJpZM4KMD7s>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] log4net issue #35: Wip/app settings
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/log4net/pull/35
I've added your converter, many thanks.
Tests would be good and we need documentation before we can close LOG4NET-526.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---