[GitHub] tmaret commented on a change in pull request #12: SLING-7754: implementation of Resource Based Queues

[GitBox <gi...@apache.org>]

tmaret commented on a change in pull request #12: SLING-7754: implementation of Resource Based Queues
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/12#discussion_r224308100
 
 

 ##########
 File path: src/main/java/org/apache/sling/distribution/queue/impl/resource/ResourceIterator.java
 ##########
 @@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.sling.distribution.queue.impl.resource;
+
+
+import org.apache.sling.api.resource.Resource;
+
+import java.util.Iterator;
+import java.util.Stack;
+
+public class ResourceIterator implements Iterator<Resource> {
 
 Review comment:
   IIUC, this iterator is central to the resource based queue implementation and has to I. reverse the natural order for `sling:OrderedFolder` which puts the head items/folders at the "end" of folder and II. flatten the date based hierarchy of `sling:OrderedFolder`. It is also configurable, thus I suggest to add a few tests to cover its behaviour.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services