You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/24 11:30:32 UTC

[GitHub] [doris] cambyzju opened a new pull request, #14556: [enhancement](outfile) add retry for broker pwrite

cambyzju opened a new pull request, #14556:
URL: https://github.com/apache/doris/pull/14556

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Problem:
   We got following error frequently while `SELECT xxx INTO OUTFILE`:
   `ERROR 1064 (HY000): RpcException, msg: Fail to write to broker, broker:TNetworkAddress(hostname=a.b.c.d, port=8111) failed:write() send(): Broken pipe`
   
   Reason:
   1. we cache broker thrift client in BE;
   2. thrift client check connect `isOpen` only return cached flag, not care the real socket is opened or closed;
   3. after we get client from cache, the socket may already closed, then `pwrite` will failed.
   
   How to fix:
   Other interfaces such as open and close, will reopen and retry again, but `pwrite` do not retry.
   As there are write offset inside `pwrite`, and the broker(server) side also will check the write offset, it is safe to retry `pwrite`.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   4. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   5. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   6. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   7. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #14556: [enhancement](outfile) add retry for broker pwrite

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14556:
URL: https://github.com/apache/doris/pull/14556#issuecomment-1326386904

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 35.39 seconds
    load time: 459 seconds
    storage size: 17149540021 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221124123031_clickbench_pr_52241.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #14556: [enhancement](outfile) add retry for broker pwrite

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14556:
URL: https://github.com/apache/doris/pull/14556#issuecomment-1326943399

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei merged pull request #14556: [enhancement](outfile) add retry for broker pwrite

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #14556:
URL: https://github.com/apache/doris/pull/14556


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #14556: [enhancement](outfile) add retry for broker pwrite

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14556:
URL: https://github.com/apache/doris/pull/14556#issuecomment-1326943416

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org