You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/03/14 19:54:37 UTC

Review Request 19230: Ambari should install Hive metastore DB schema using SchemaTool

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19230/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk and Ashutosh Chauhan.


Bugs: AMBARI-5091
    https://issues.apache.org/jira/browse/AMBARI-5091


Repository: ambari


Description
-------

Currently it relies on autoCreate=true. This was optional (though not recommended) before Baikal. But starting Baikal this is strictly required because new transaction feature coming up in Baikal Hive won't work correctly in absence of this.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/schemaTool.sh PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py c741174 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 2b4a0d9 

Diff: https://reviews.apache.org/r/19230/diff/


Testing
-------


Thanks,

Dmytro Sen


Re: Review Request 19230: Ambari should install Hive metastore DB schema using SchemaTool

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19230/#review38594
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On March 25, 2014, 7:34 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19230/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 7:34 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Ashutosh Chauhan.
> 
> 
> Bugs: AMBARI-5091
>     https://issues.apache.org/jira/browse/AMBARI-5091
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently it relies on autoCreate=true. This was optional (though not recommended) before Baikal. But starting Baikal this is strictly required because new transaction feature coming up in Baikal Hive won't work correctly in absence of this.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py c741174 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 2b4a0d9 
>   ambari-server/src/main/resources/stacks/HDP/2.1/role_command_order.json 60c2d20 
> 
> Diff: https://reviews.apache.org/r/19230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 19230: Ambari should install Hive metastore DB schema using SchemaTool

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19230/
-----------------------------------------------------------

(Updated March 26, 2014, 1:54 p.m.)


Review request for Ambari, Andrew Onischuk and Ashutosh Chauhan.


Bugs: AMBARI-5091
    https://issues.apache.org/jira/browse/AMBARI-5091


Repository: ambari


Description
-------

Currently it relies on autoCreate=true. This was optional (though not recommended) before Baikal. But starting Baikal this is strictly required because new transaction feature coming up in Baikal Hive won't work correctly in absence of this.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py c741174 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 2b4a0d9 
  ambari-server/src/main/resources/stacks/HDP/2.1/role_command_order.json 60c2d20 

Diff: https://reviews.apache.org/r/19230/diff/


Testing (updated)
-------

Tested end-to-end on HDP2.0 and HDP2.1
For HDP2.0 schematool isn't used


Thanks,

Dmytro Sen


Re: Review Request 19230: Ambari should install Hive metastore DB schema using SchemaTool

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19230/
-----------------------------------------------------------

(Updated March 25, 2014, 7:34 p.m.)


Review request for Ambari, Andrew Onischuk and Ashutosh Chauhan.


Changes
-------

Tested end-to-end on HDP2.0 and HDP2.1
For HDP2.0 schematool isn't used


Bugs: AMBARI-5091
    https://issues.apache.org/jira/browse/AMBARI-5091


Repository: ambari


Description
-------

Currently it relies on autoCreate=true. This was optional (though not recommended) before Baikal. But starting Baikal this is strictly required because new transaction feature coming up in Baikal Hive won't work correctly in absence of this.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py c741174 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 2b4a0d9 
  ambari-server/src/main/resources/stacks/HDP/2.1/role_command_order.json 60c2d20 

Diff: https://reviews.apache.org/r/19230/diff/


Testing
-------


Thanks,

Dmytro Sen


Re: Review Request 19230: Ambari should install Hive metastore DB schema using SchemaTool

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19230/
-----------------------------------------------------------

(Updated March 24, 2014, 5:15 p.m.)


Review request for Ambari, Andrew Onischuk and Ashutosh Chauhan.


Bugs: AMBARI-5091
    https://issues.apache.org/jira/browse/AMBARI-5091


Repository: ambari


Description
-------

Currently it relies on autoCreate=true. This was optional (though not recommended) before Baikal. But starting Baikal this is strictly required because new transaction feature coming up in Baikal Hive won't work correctly in absence of this.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json 550f885 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py c741174 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 2b4a0d9 
  ambari-server/src/main/resources/stacks/HDP/2.1/role_command_order.json 60c2d20 

Diff: https://reviews.apache.org/r/19230/diff/


Testing
-------


Thanks,

Dmytro Sen


Re: Review Request 19230: Ambari should install Hive metastore DB schema using SchemaTool

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19230/#review37266
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On March 14, 2014, 7:54 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19230/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 7:54 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Ashutosh Chauhan.
> 
> 
> Bugs: AMBARI-5091
>     https://issues.apache.org/jira/browse/AMBARI-5091
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently it relies on autoCreate=true. This was optional (though not recommended) before Baikal. But starting Baikal this is strictly required because new transaction feature coming up in Baikal Hive won't work correctly in absence of this.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/schemaTool.sh PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py c741174 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 2b4a0d9 
> 
> Diff: https://reviews.apache.org/r/19230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 19230: Ambari should install Hive metastore DB schema using SchemaTool

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19230/
-----------------------------------------------------------

(Updated March 14, 2014, 7:54 p.m.)


Review request for Ambari, Andrew Onischuk and Ashutosh Chauhan.


Bugs: AMBARI-5091
    https://issues.apache.org/jira/browse/AMBARI-5091


Repository: ambari


Description
-------

Currently it relies on autoCreate=true. This was optional (though not recommended) before Baikal. But starting Baikal this is strictly required because new transaction feature coming up in Baikal Hive won't work correctly in absence of this.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/schemaTool.sh PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py c741174 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 2b4a0d9 

Diff: https://reviews.apache.org/r/19230/diff/


Testing
-------


Thanks,

Dmytro Sen


Re: Review Request 19230: Ambari should install Hive metastore DB schema using SchemaTool

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19230/
-----------------------------------------------------------

(Updated March 14, 2014, 7:52 p.m.)


Review request for Ambari, Andrew Onischuk and Ashutosh Chauhan.


Bugs: AMBARI-5091
    https://issues.apache.org/jira/browse/AMBARI-5091


Repository: ambari


Description
-------

Currently it relies on autoCreate=true. This was optional (though not recommended) before Baikal. But starting Baikal this is strictly required because new transaction feature coming up in Baikal Hive won't work correctly in absence of this.


Diffs (updated)
-----

  ambari-web/app/controllers/main/host.js 240a98a 
  ambari-web/app/controllers/main/host/details.js 870a9f6 
  ambari-web/app/templates/main/host/details/host_component.hbs 2e54629 
  ambari-web/app/views/main/host/hosts_table_menu_view.js 7e185fe 
  ambari-web/test/controllers/main/host_test.js 97294a6 

Diff: https://reviews.apache.org/r/19230/diff/


Testing
-------


Thanks,

Dmytro Sen


Re: Review Request 19230: Ambari should install Hive metastore DB schema using SchemaTool

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19230/
-----------------------------------------------------------

(Updated March 14, 2014, 7:45 p.m.)


Review request for Ambari, Andrew Onischuk and Ashutosh Chauhan.


Bugs: AMBARI-5091
    https://issues.apache.org/jira/browse/AMBARI-5091


Repository: ambari


Description
-------

Currently it relies on autoCreate=true. This was optional (though not recommended) before Baikal. But starting Baikal this is strictly required because new transaction feature coming up in Baikal Hive won't work correctly in absence of this.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/schemaTool.sh PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py c741174 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 2b4a0d9 

Diff: https://reviews.apache.org/r/19230/diff/


Testing
-------


Thanks,

Dmytro Sen


Re: Review Request 19230: Ambari should install Hive metastore DB schema using SchemaTool

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19230/#review37249
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py
<https://reviews.apache.org/r/19230/#comment68668>

    __x__ -- magic method
    _x -- 'private' method


- Andrew Onischuk


On March 14, 2014, 6:54 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19230/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 6:54 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Ashutosh Chauhan.
> 
> 
> Bugs: AMBARI-5091
>     https://issues.apache.org/jira/browse/AMBARI-5091
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently it relies on autoCreate=true. This was optional (though not recommended) before Baikal. But starting Baikal this is strictly required because new transaction feature coming up in Baikal Hive won't work correctly in absence of this.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/files/schemaTool.sh PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_metastore.py c741174 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 2b4a0d9 
> 
> Diff: https://reviews.apache.org/r/19230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>