You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sentry.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2018/03/30 15:26:00 UTC

[jira] [Commented] (SENTRY-2193) Synchronize thrift definition with the generated sources

    [ https://issues.apache.org/jira/browse/SENTRY-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420614#comment-16420614 ] 

Hadoop QA commented on SENTRY-2193:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12917023/SENTRY-2193.001.patch against master.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3725/console

This message is automatically generated.

> Synchronize thrift definition with the generated sources
> --------------------------------------------------------
>
>                 Key: SENTRY-2193
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2193
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.1.0
>            Reporter: kalyan kumar kalvagadda
>            Assignee: kalyan kumar kalvagadda
>            Priority: Major
>             Fix For: 2.1.0
>
>         Attachments: SENTRY-2193.001.patch
>
>
> Current thrift definition is not in-line with the the generated source. I suspect that some of the commits that performed thrift changes did not commit some of the files that are updated.
> This would have been the case as the all the generated files were updated because of the date change. Committers have an habbit of reverting the changes. In that process some one would have reverted some of the changes that are made.
> Intent of this change is Synchronize thrift definition with the generated sources. Once this we synchronize them and run below command only changes one should be seeing are the date changes.
>  
> {noformat}
> mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local/
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)