You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/18 16:10:48 UTC
[GitHub] [flink] wenlong88 opened a new pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
wenlong88 opened a new pull request #15272:
URL: https://github.com/apache/flink/pull/15272
## What is the purpose of the change
Suport json ser/de for StreamExecMatch
## Brief change log
1. Support json ser/de for pattern RexCall
2. Suport json ser/de for StreamExecMatch
## Verifying this change
This change added tests and can be verified as follows:
1. MatchRecognizeJsonPlanTest and MatchRecognizeJsonPlanITCase are added to verify the ser/de
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #15272:
URL: https://github.com/apache/flink/pull/15272#discussion_r597400191
##########
File path: flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/runtime/stream/jsonplan/MatchRecognizeJsonPlanITCase.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.runtime.stream.jsonplan;
+
+import org.apache.flink.table.planner.factories.TestValuesTableFactory;
+import org.apache.flink.table.planner.utils.JsonPlanTestBase;
+import org.apache.flink.types.Row;
+
+import org.junit.Test;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.ExecutionException;
+
+/** Test json deserialization for match recognize. */
+public class MatchRecognizeJsonPlanITCase extends JsonPlanTestBase {
+ @Test
+ public void testSimpleMatch() throws ExecutionException, InterruptedException, IOException {
Review comment:
nit: `throws Exception` is enough
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexNodeJsonSerializer.java
##########
@@ -113,6 +117,9 @@ public void serialize(
case CORREL_VARIABLE:
serialize((RexCorrelVariable) rexNode, jsonGenerator);
break;
+ case PATTERN_INPUT_REF:
Review comment:
please add some tests in `RexNodeSerdeTest`
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexNodeJsonDeserializer.java
##########
@@ -334,6 +351,21 @@ private SqlOperator toOperator(JsonNode jsonNode, SerdeContext ctx) throws IOExc
}
}
+ // try to find operator from std operator table.
+ SqlStdOperatorTable.instance()
Review comment:
does `ctx.getOperatorTable()` contain all operators used in Flink ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #15272:
URL: https://github.com/apache/flink/pull/15272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802067367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e96eaf020bcec88f7e5364264f15ac4bf6ed34b4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802067367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987",
"triggerID" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"triggerType" : "PUSH"
}, {
"hash" : "2542929c02c33edd9817274c8c329949ee27a505",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15007",
"triggerID" : "2542929c02c33edd9817274c8c329949ee27a505",
"triggerType" : "PUSH"
}, {
"hash" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e96eaf020bcec88f7e5364264f15ac4bf6ed34b4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987)
* 2542929c02c33edd9817274c8c329949ee27a505 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15007)
* 826d695c88ff0250a44d950a3494ade0bfd63bbb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802067367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987",
"triggerID" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e96eaf020bcec88f7e5364264f15ac4bf6ed34b4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802067367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987",
"triggerID" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"triggerType" : "PUSH"
}, {
"hash" : "2542929c02c33edd9817274c8c329949ee27a505",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15007",
"triggerID" : "2542929c02c33edd9817274c8c329949ee27a505",
"triggerType" : "PUSH"
}, {
"hash" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15015",
"triggerID" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"triggerType" : "PUSH"
}, {
"hash" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15017",
"triggerID" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"triggerType" : "PUSH"
}, {
"hash" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15059",
"triggerID" : "802777967",
"triggerType" : "MANUAL"
}, {
"hash" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15017",
"triggerID" : "802777967",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 2be101d2ed755846ad22218f45624a1da53f4d1c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15059) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15017)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802067367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987",
"triggerID" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"triggerType" : "PUSH"
}, {
"hash" : "2542929c02c33edd9817274c8c329949ee27a505",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2542929c02c33edd9817274c8c329949ee27a505",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e96eaf020bcec88f7e5364264f15ac4bf6ed34b4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987)
* 2542929c02c33edd9817274c8c329949ee27a505 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802056787
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e96eaf020bcec88f7e5364264f15ac4bf6ed34b4 (Thu Mar 18 16:12:55 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802067367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987",
"triggerID" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"triggerType" : "PUSH"
}, {
"hash" : "2542929c02c33edd9817274c8c329949ee27a505",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15007",
"triggerID" : "2542929c02c33edd9817274c8c329949ee27a505",
"triggerType" : "PUSH"
}, {
"hash" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15015",
"triggerID" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"triggerType" : "PUSH"
}, {
"hash" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15017",
"triggerID" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"triggerType" : "PUSH"
}, {
"hash" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15059",
"triggerID" : "802777967",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 2be101d2ed755846ad22218f45624a1da53f4d1c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15017) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15059)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802067367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987",
"triggerID" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e96eaf020bcec88f7e5364264f15ac4bf6ed34b4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802067367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987",
"triggerID" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"triggerType" : "PUSH"
}, {
"hash" : "2542929c02c33edd9817274c8c329949ee27a505",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15007",
"triggerID" : "2542929c02c33edd9817274c8c329949ee27a505",
"triggerType" : "PUSH"
}, {
"hash" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15015",
"triggerID" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"triggerType" : "PUSH"
}, {
"hash" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15017",
"triggerID" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2be101d2ed755846ad22218f45624a1da53f4d1c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15017)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802067367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987",
"triggerID" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"triggerType" : "PUSH"
}, {
"hash" : "2542929c02c33edd9817274c8c329949ee27a505",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15007",
"triggerID" : "2542929c02c33edd9817274c8c329949ee27a505",
"triggerType" : "PUSH"
}, {
"hash" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15015",
"triggerID" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"triggerType" : "PUSH"
}, {
"hash" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15017",
"triggerID" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"triggerType" : "PUSH"
}, {
"hash" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15059",
"triggerID" : "802777967",
"triggerType" : "MANUAL"
}, {
"hash" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15017",
"triggerID" : "802777967",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 2be101d2ed755846ad22218f45624a1da53f4d1c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15059) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15017)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802777967
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wenlong88 commented on a change in pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
wenlong88 commented on a change in pull request #15272:
URL: https://github.com/apache/flink/pull/15272#discussion_r597419515
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexNodeJsonDeserializer.java
##########
@@ -334,6 +351,21 @@ private SqlOperator toOperator(JsonNode jsonNode, SerdeContext ctx) throws IOExc
}
}
+ // try to find operator from std operator table.
+ SqlStdOperatorTable.instance()
Review comment:
no, that is why I add this code, FlinkSqlOperatorTable dosen't not cover all of the operator, and I found that we use some operator like PATTERN_CONCAT directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802067367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987",
"triggerID" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"triggerType" : "PUSH"
}, {
"hash" : "2542929c02c33edd9817274c8c329949ee27a505",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15007",
"triggerID" : "2542929c02c33edd9817274c8c329949ee27a505",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e96eaf020bcec88f7e5364264f15ac4bf6ed34b4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987)
* 2542929c02c33edd9817274c8c329949ee27a505 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15007)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802067367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987",
"triggerID" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"triggerType" : "PUSH"
}, {
"hash" : "2542929c02c33edd9817274c8c329949ee27a505",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15007",
"triggerID" : "2542929c02c33edd9817274c8c329949ee27a505",
"triggerType" : "PUSH"
}, {
"hash" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15015",
"triggerID" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"triggerType" : "PUSH"
}, {
"hash" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e96eaf020bcec88f7e5364264f15ac4bf6ed34b4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987)
* 2542929c02c33edd9817274c8c329949ee27a505 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15007)
* 826d695c88ff0250a44d950a3494ade0bfd63bbb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15015)
* 2be101d2ed755846ad22218f45624a1da53f4d1c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15272: [FLINK-21816][table-planner-blink] Suport json ser/de for StreamExecMatch
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15272:
URL: https://github.com/apache/flink/pull/15272#issuecomment-802067367
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14987",
"triggerID" : "e96eaf020bcec88f7e5364264f15ac4bf6ed34b4",
"triggerType" : "PUSH"
}, {
"hash" : "2542929c02c33edd9817274c8c329949ee27a505",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15007",
"triggerID" : "2542929c02c33edd9817274c8c329949ee27a505",
"triggerType" : "PUSH"
}, {
"hash" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15015",
"triggerID" : "826d695c88ff0250a44d950a3494ade0bfd63bbb",
"triggerType" : "PUSH"
}, {
"hash" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15017",
"triggerID" : "2be101d2ed755846ad22218f45624a1da53f4d1c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 826d695c88ff0250a44d950a3494ade0bfd63bbb Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15015)
* 2be101d2ed755846ad22218f45624a1da53f4d1c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15017)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org