You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2024/03/25 03:52:55 UTC

Re: [PR] [SPARK-47538][BUILD] Remove `commons-logging` dependency [spark]

dongjoon-hyun commented on code in PR #45687:
URL: https://github.com/apache/spark/pull/45687#discussion_r1537028358


##########
pom.xml:
##########
@@ -651,12 +651,6 @@
         <artifactId>commons-beanutils</artifactId>
         <version>1.9.4</version>
       </dependency>
-      <dependency>
-        <groupId>commons-logging</groupId>
-        <artifactId>commons-logging</artifactId>
-        <!-- Hive uses commons-logging 1.1.3 from 0.13 to 1.2 -->

Review Comment:
   For the record, since Apache Hive 2.0.0 removed direct commons-logging dependency via [HIVE-12237 Use slf4j as logging facade](https://issues.apache.org/jira/browse/HIVE-12237), we don't need this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org