[GitHub] [pulsar] epsteina16 commented on issue #4768: Expose acknowledgment flushing capabilities at the consumer level

[GitBox <gi...@apache.org>]

epsteina16 commented on issue #4768: Expose acknowledgment flushing capabilities at the consumer level
URL: https://github.com/apache/pulsar/pull/4768#issuecomment-519106823
 
 
   @sijie Maybe we can continue with this, and throw an exception if the flush doesn't got through because of [these lines](https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java#L153-L158)? 
   
   This behavior also seems to be present in plenty of other places (not responding to unexpected behavior with exceptions). For example, [these lines](https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java#L136-138) can result in acks not being sent and no exception thrown to let the user know.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services