You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2020/12/28 05:44:44 UTC
[incubator-echarts] 02/02: add todo mark comments
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch treeshakable-exports
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 6e38bc5bcc651b4b463a0b4be287ce8a9d15d664
Author: pissang <bm...@gmail.com>
AuthorDate: Mon Dec 28 13:44:04 2020 +0800
add todo mark comments
---
src/component/helper/interactionMutex.ts | 2 +-
src/component/toolbox/feature/DataView.ts | 2 ++
src/component/toolbox/feature/MagicType.ts | 1 +
src/component/toolbox/feature/Restore.ts | 1 +
src/coord/cartesian/defaultAxisExtentFromData.ts | 1 +
src/export/all.ts | 1 -
6 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/component/helper/interactionMutex.ts b/src/component/helper/interactionMutex.ts
index 686475f..04e1f42 100644
--- a/src/component/helper/interactionMutex.ts
+++ b/src/component/helper/interactionMutex.ts
@@ -18,7 +18,6 @@
*/
// @ts-nocheck
-
import * as echarts from '../../echarts';
const ATTR = '\0_ec_interaction_mutex';
@@ -52,6 +51,7 @@ function getStore(zr) {
* If no userKey, release global cursor.
* }
*/
+// TODO: SELF REGISTERED.
echarts.registerAction(
{type: 'takeGlobalCursor', event: 'globalCursorTaken', update: 'update'},
function () {}
diff --git a/src/component/toolbox/feature/DataView.ts b/src/component/toolbox/feature/DataView.ts
index 1b6de33..9370ddd 100644
--- a/src/component/toolbox/feature/DataView.ts
+++ b/src/component/toolbox/feature/DataView.ts
@@ -487,6 +487,8 @@ function tryMergeDataOption(newData: DataList, originalData: DataList) {
});
}
+
+// TODO: SELF REGISTERED.
echarts.registerAction({
type: 'changeDataView',
event: 'dataViewChanged',
diff --git a/src/component/toolbox/feature/MagicType.ts b/src/component/toolbox/feature/MagicType.ts
index 4f58796..edc0b9a 100644
--- a/src/component/toolbox/feature/MagicType.ts
+++ b/src/component/toolbox/feature/MagicType.ts
@@ -231,6 +231,7 @@ const seriesOptGenreator: Record<IconType, SeriesOptGenreator> = {
};
+// TODO: SELF REGISTERED.
echarts.registerAction({
type: 'changeMagicType',
event: 'magicTypeChanged',
diff --git a/src/component/toolbox/feature/Restore.ts b/src/component/toolbox/feature/Restore.ts
index b22603b..dd9e8a5 100644
--- a/src/component/toolbox/feature/Restore.ts
+++ b/src/component/toolbox/feature/Restore.ts
@@ -51,6 +51,7 @@ class RestoreOption extends ToolboxFeature<ToolboxRestoreFeatureOption> {
}
}
+// TODO: SELF REGISTERED.
echarts.registerAction(
{type: 'restore', event: 'restore', update: 'prepareAndUpdate'},
function (payload, ecModel) {
diff --git a/src/coord/cartesian/defaultAxisExtentFromData.ts b/src/coord/cartesian/defaultAxisExtentFromData.ts
index b82391b..cd494c3 100644
--- a/src/coord/cartesian/defaultAxisExtentFromData.ts
+++ b/src/coord/cartesian/defaultAxisExtentFromData.ts
@@ -44,6 +44,7 @@ type SeriesRecord = {
// A tricky: the priority is just after dataZoom processor.
// If dataZoom has fixed the min/max, this processor do not need to work.
+// TODO: SELF REGISTERED.
echarts.registerProcessor(echarts.PRIORITY.PROCESSOR.FILTER + 10, {
getTargetSeries: function (ecModel) {
diff --git a/src/export/all.ts b/src/export/all.ts
index 678c5d5..41b7420 100644
--- a/src/export/all.ts
+++ b/src/export/all.ts
@@ -18,7 +18,6 @@
*/
// This file is for providing types when import whole module.
-// import * as echarts from 'echarts'
export * from './core';
export * from './option';
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org