You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Colin McCabe (Jira)" <ji...@apache.org> on 2024/08/09 22:45:00 UTC
[jira] [Commented] (KAFKA-15969) Align RemoteStorageThreadPool metrics name with KIP-405
[ https://issues.apache.org/jira/browse/KAFKA-15969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872494#comment-17872494 ]
Colin McCabe commented on KAFKA-15969:
--------------------------------------
Kafka 3.6 was released quite a while ago. Changing the metric names at this point would require a KIP.
Moving to 4.0 since we are past KIP freeze for 3.9.
> Align RemoteStorageThreadPool metrics name with KIP-405
> -------------------------------------------------------
>
> Key: KAFKA-15969
> URL: https://issues.apache.org/jira/browse/KAFKA-15969
> Project: Kafka
> Issue Type: Bug
> Components: metrics
> Affects Versions: 3.6.0
> Reporter: Lixin Yao
> Priority: Minor
> Fix For: 3.9.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> In KIP-405, there are 2 metrics defined below:
> ^kafka.log.remote:type=RemoteStorageThreadPool, name=RemoteLogReaderTaskQueueSize^
> and
> ^kafka.log.remote:type=RemoteStorageThreadPool, name=RemoteLogReaderAvgIdlePercent^
> However, in Kafka 3.6 release, the actual metrics exposes are:
> ^org.apache.kafka.storage.internals.log:name=RemoteLogReaderAvgIdlePercent,type=RemoteStorageThreadPool^
> ^org.apache.kafka.storage.internals.log:name=RemoteLogReaderTaskQueueSize,type=RemoteStorageThreadPool^
> The problem is the bean domain name is changed from ^{{kafka.log.remote}}^ to {{{}^org.apache.kafka.storage.internals.log^{}}}. And the type name is also changed.
> We should either update the metrics path in KIP, or fix the path in the code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)